[webkit-changes] [WebKit/WebKit] 10fc80: REGRESSION(287916 at main): stack overflow in JSStrin...

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 10fc803b93145f9799b11a1a2c43c2f43f1e2bce
      https://github.com/WebKit/WebKit/commit/10fc803b93145f9799b11a1a2c43c2f43f1e2bce
  Author: Fujii Hironori <Hironori.Fujii at sony.com>
  Date:   2024-12-17 (Tue, 17 Dec 2024)

  Changed paths:
    M Source/JavaScriptCore/runtime/JSStringInlines.h
    M Source/WTF/wtf/Compiler.h

  Log Message:
  -----------
  REGRESSION(287916 at main): stack overflow in JSString::resolveToBuffer
https://bugs.webkit.org/show_bug.cgi?id=284809

Reviewed by Yusuke Suzuki.

After <https://commits.webkit.org/287916@main> removed the stack
height check for JSString::resolveToBuffer, some tests were crashing
for Windows port. Windows and PowerPC doesn't support
[[clang::musttail]].

Use resolveToBufferSlow instead for the platforms. Added
HAVE_MUST_TAIL_CALL macro.

* Source/JavaScriptCore/runtime/JSStringInlines.h:
(JSC::JSRopeString::resolveToBuffer):
* Source/WTF/wtf/Compiler.h:

Canonical link: https://commits.webkit.org/287956@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications