[webkit-changes] [WebKit/WebKit] cda4b5: Fix clang static analyzer warning in RemoteLayerTr...

Ryosuke Niwa noreply at github.com
Tue Dec 17 10:38:03 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cda4b5fd08c5c7ac0b5ea9ebdc8edc19ae943585
      https://github.com/WebKit/WebKit/commit/cda4b5fd08c5c7ac0b5ea9ebdc8edc19ae943585
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2024-12-17 (Tue, 17 Dec 2024)

  Changed paths:
    M Source/WebKit/UIProcess/DrawingAreaProxy.h
    M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.h
    M Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeDrawingAreaProxyIOS.h
    M Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.mm
    M Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeDrawingAreaProxyMac.h
    M Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeEventDispatcher.cpp

  Log Message:
  -----------
  Fix clang static analyzer warning in RemoteLayerTreeEventDispatcher::drawingAreaMac
https://bugs.webkit.org/show_bug.cgi?id=284787

Reviewed by Anne van Kesteren and Chris Dumez.

Directly cast to RemoteLayerTreeDrawingAreaProxyMac and RemoteLayerTreeDrawingAreaProxyIOS in
respective translation units instead of debug-only asserting the type.

* Source/WebKit/UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::isRemoteLayerTreeDrawingAreaProxyMac const):
(WebKit::DrawingAreaProxy::isRemoteLayerTreeDrawingAreaProxyIOS const):
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.h:
(WebKit::RemoteLayerTreeDrawingAreaProxy::isRemoteLayerTreeDrawingAreaProxyMac const): Deleted.
(WebKit::RemoteLayerTreeDrawingAreaProxy::isRemoteLayerTreeDrawingAreaProxyIOS const): Deleted.
* Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeDrawingAreaProxyIOS.h:
(isType):
* Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.mm:
(WebKit::RemoteScrollingCoordinatorProxyIOS::drawingAreaIOS const):
* Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeDrawingAreaProxyMac.h:
(isType):
* Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeEventDispatcher.cpp:
(WebKit::RemoteLayerTreeEventDispatcher::drawingAreaMac const):

Canonical link: https://commits.webkit.org/287953@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list