[webkit-changes] [WebKit/WebKit] da5a8f: Make comparing FontCascades more efficient

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: da5a8f93cdeaa0e6861177e66e29cda6b59596cb
      https://github.com/WebKit/WebKit/commit/da5a8f93cdeaa0e6861177e66e29cda6b59596cb
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2024-12-17 (Tue, 17 Dec 2024)

  Changed paths:
    M Source/WebCore/accessibility/AXObjectCache.cpp
    M Source/WebCore/layout/formattingContexts/inline/AbstractLineBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/invalidation/InlineInvalidation.cpp
    M Source/WebCore/layout/integration/LayoutIntegrationBoxTreeUpdater.cpp
    M Source/WebCore/rendering/RenderCombineText.cpp
    M Source/WebCore/rendering/RenderImage.cpp
    M Source/WebCore/rendering/RenderMenuList.cpp
    M Source/WebCore/rendering/RenderText.cpp
    M Source/WebCore/rendering/style/RenderStyle.h
    M Source/WebCore/rendering/style/RenderStyleInlines.h
    M Source/WebCore/style/StyleTreeResolver.cpp

  Log Message:
  -----------
  Make comparing FontCascades more efficient
https://bugs.webkit.org/show_bug.cgi?id=284583
rdar://141401574

Reviewed by Dan Glastonbury.

Call sites that currently compare FontCascade on two RenderStyles, which is slow, now call
`RenderStyle::fontCascadeEqual()`, which checks to see if the m_inheritedData and
m_inheritedData->fontData pointers are equal before doing the more expensive comparison.

* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::onStyleChange):
* Source/WebCore/layout/formattingContexts/inline/AbstractLineBuilder.cpp:
(WebCore::Layout::AbstractLineBuilder::eligibleOverflowWidthAsLeading const):
* Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp:
(WebCore::Layout::InlineContentBreaker::tryHyphenationAcrossOverflowingInlineTextItems const):
* Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:
(WebCore::Layout::canCacheMeasuredWidthOnInlineTextItem):
* Source/WebCore/layout/formattingContexts/inline/invalidation/InlineInvalidation.cpp:
(WebCore::Layout::InlineInvalidation::rootStyleWillChange):
(WebCore::Layout::InlineInvalidation::styleWillChange):
* Source/WebCore/layout/integration/LayoutIntegrationBoxTreeUpdater.cpp:
(WebCore::LayoutIntegration::updateContentCharacteristic):
* Source/WebCore/rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
* Source/WebCore/rendering/RenderImage.cpp:
* Source/WebCore/rendering/RenderMenuList.cpp:
(RenderMenuList::styleDidChange):
* Source/WebCore/rendering/RenderText.cpp:
(WebCore::RenderText::styleDidChange):
* Source/WebCore/rendering/style/RenderStyle.h:
* Source/WebCore/rendering/style/RenderStyleInlines.h:
(WebCore::RenderStyle::fontCascadeEqual const):
* Source/WebCore/style/StyleTreeResolver.cpp:
(WebCore::Style::styleChangeAffectsRelativeUnits):

Canonical link: https://commits.webkit.org/287949@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications