[webkit-changes] [WebKit/WebKit] e18000: [Cleanup] Move hasAutoHeightOrContainingBlockWithA...

Alan Baradlay noreply at github.com
Tue Dec 17 08:17:47 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e1800036405ce800b0277dbb1c1e6f885fdb8224
      https://github.com/WebKit/WebKit/commit/e1800036405ce800b0277dbb1c1e6f885fdb8224
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-12-17 (Tue, 17 Dec 2024)

  Changed paths:
    M Source/WebCore/layout/integration/flex/LayoutIntegrationFlexLayout.cpp
    M Source/WebCore/rendering/RenderBox.cpp
    M Source/WebCore/rendering/RenderBox.h
    M Source/WebCore/rendering/RenderBoxModelObject.cpp
    M Source/WebCore/rendering/RenderBoxModelObject.h

  Log Message:
  -----------
  [Cleanup] Move hasAutoHeightOrContainingBlockWithAutoHeight from RenderBoxModelObject to RenderBox
https://bugs.webkit.org/show_bug.cgi?id=284794

Reviewed by Antti Koivisto.

This function starts with

  auto* thisBox = dynamicDowncast<RenderBox>(this);

and we keep checking if 'thisBox' is not nullptr, when in reality we only call this function on a RenderBox.

* Source/WebCore/layout/integration/flex/LayoutIntegrationFlexLayout.cpp:
(WebCore::LayoutIntegration::constraintsForFlexContent):
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::hasAutoHeightOrContainingBlockWithAutoHeight const):
* Source/WebCore/rendering/RenderBox.h:
* Source/WebCore/rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::containingBlockForAutoHeightDetection const):
(WebCore::RenderBoxModelObject::hasAutoHeightOrContainingBlockWithAutoHeight const): Deleted.
* Source/WebCore/rendering/RenderBoxModelObject.h:

Canonical link: https://commits.webkit.org/287945@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list