[webkit-changes] [WebKit/WebKit] 18e3c0: [Cleanup] RenderBoxModelObject::relativePositionOf...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 18e3c0b0e5c98b16f4ec64741b6b6c1cc5dcec1e
      https://github.com/WebKit/WebKit/commit/18e3c0b0e5c98b16f4ec64741b6b6c1cc5dcec1e
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-12-17 (Tue, 17 Dec 2024)

  Changed paths:
    M Source/WebCore/rendering/RenderBoxModelObject.cpp

  Log Message:
  -----------
  [Cleanup] RenderBoxModelObject::relativePositionOffset should only check for "overriding containing block" values on grid items
https://bugs.webkit.org/show_bug.cgi?id=284784

Reviewed by Antti Koivisto.

1. Grid item's containing block is the grid area (which may or may not match the grid box)
2. WebKit does not have a renderer representing this "area"
3. "overriding containing block width/height" was added to ensure we can read
non-containing block values as constraints for grid items.
4. Flex layout also uses this "overriding" concept to temporarily override constrains when flexing (during layout).

RenderBoxModelObject::relativePositionOffset is called _after_ layout, so this is logic
should be about grid vs. all the other types.

* Source/WebCore/rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::relativePositionOffset const):

Canonical link: https://commits.webkit.org/287940@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications