[webkit-changes] [WebKit/WebKit] 33acc7: REGRESSION(287851 at main): Crash under `HTMLTextForm...

Tim Nguyen noreply at github.com
Tue Dec 17 01:32:55 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 33acc7313b66be9cbcf588a9b1e3529bb708d4a7
      https://github.com/WebKit/WebKit/commit/33acc7313b66be9cbcf588a9b1e3529bb708d4a7
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2024-12-17 (Tue, 17 Dec 2024)

  Changed paths:
    A LayoutTests/editing/selection/setSelectionRange-no-frame-crash-expected.txt
    A LayoutTests/editing/selection/setSelectionRange-no-frame-crash.html
    M Source/WebCore/html/HTMLTextFormControlElement.cpp

  Log Message:
  -----------
  REGRESSION(287851 at main): Crash under `HTMLTextFormControlElement::setSelectionRange`
https://bugs.webkit.org/show_bug.cgi?id=284798
rdar://141585652

Reviewed by Ryosuke Niwa.

Check if frame is null before consulting the frame selection.

Testcase from Ryosuke Niwa.

* LayoutTests/editing/selection/setSelectionRange-no-frame-crash-expected.txt: Added.
* LayoutTests/editing/selection/setSelectionRange-no-frame-crash.html: Added.
* Source/WebCore/html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::setSelectionRange):

Canonical link: https://commits.webkit.org/287929@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list