[webkit-changes] [WebKit/WebKit] 2ffc14: [iOS18] 2 tests in TestWebKitAPI.WebKit.SystemPrev...

Wenson Hsieh noreply at github.com
Mon Dec 16 15:36:17 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2ffc143345427497f3ba39da7992a97f7ee62a84
      https://github.com/WebKit/WebKit/commit/2ffc143345427497f3ba39da7992a97f7ee62a84
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2024-12-16 (Mon, 16 Dec 2024)

  Changed paths:
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/SystemPreview.mm

  Log Message:
  -----------
  [iOS18] 2 tests in TestWebKitAPI.WebKit.SystemPreview are a constant crash(failure in EWS)
https://bugs.webkit.org/show_bug.cgi?id=284572
rdar://141378456

Reviewed by Abrar Rahman Protyasha.

Fix these test failures after updating to iOS 18 by deploying `TestWKWebViewController` here.
Importantly, this testing helper class works around the lack of UIApp in TestWebKitAPI by
intercepting the view controller animated dismissal hook.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/SystemPreview.mm:
(TestWebKitAPI::TEST(WebKit, SystemPreviewFail)):
(TestWebKitAPI::TEST(WebKit, SystemPreviewBlob)):

Canonical link: https://commits.webkit.org/287914@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list