[webkit-changes] [WebKit/WebKit] 424254: generic font families are undefined for SVG images

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 42425440a3345429aa0f113d5c7e7cd5eec5a501
      https://github.com/WebKit/WebKit/commit/42425440a3345429aa0f113d5c7e7cd5eec5a501
  Author: Fujii Hironori <Hironori.Fujii at sony.com>
  Date:   2024-12-16 (Mon, 16 Dec 2024)

  Changed paths:
    M Source/WebCore/loader/cache/CachedImage.cpp
    M Source/WebCore/loader/cache/CachedImage.h
    M Source/WebCore/platform/graphics/ImageObserver.h
    M Source/WebCore/svg/graphics/SVGImage.cpp

  Log Message:
  -----------
  generic font families are undefined for SVG images
https://bugs.webkit.org/show_bug.cgi?id=20846

Reviewed by Simon Fraser.

SVGImage has a Page to parse and draw an SVG document. And, the Page
has own Settings. But, generic font families settings weren't set.

Added ImageObserver::settings() interface to get a Settings of the
owner document. Removed ImageObserver::layerBasedSVGEngineEnabled by
replacing with settings().

* Source/WebCore/loader/cache/CachedImage.cpp:
(WebCore::CachedImage::load):
* Source/WebCore/loader/cache/CachedImage.h:
* Source/WebCore/platform/graphics/ImageObserver.h:
(WebCore::ImageObserver::settings):
(WebCore::ImageObserver::layerBasedSVGEngineEnabled const): Deleted.
* Source/WebCore/svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::dataChanged):

Canonical link: https://commits.webkit.org/287903@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications