[webkit-changes] [WebKit/WebKit] 76a2b2: Cleanup StyledElement usage in PDFPlugin

Anne van Kesteren noreply at github.com
Mon Dec 16 10:12:31 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 76a2b2aa39ec7bcd9f0a976eed7d634e443e05fe
      https://github.com/WebKit/WebKit/commit/76a2b2aa39ec7bcd9f0a976eed7d634e443e05fe
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2024-12-16 (Mon, 16 Dec 2024)

  Changed paths:
    M Source/WebKit/SaferCPPExpectations/MemoryUnsafeCastCheckerExpectations
    M Source/WebKit/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginAnnotation.mm
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginPasswordForm.mm
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm

  Log Message:
  -----------
  Cleanup StyledElement usage in PDFPlugin
https://bugs.webkit.org/show_bug.cgi?id=284690

Reviewed by Tim Nguyen.

In particular in PDFPluginPasswordForm it isn't needed at all.

* Source/WebKit/SaferCPPExpectations/MemoryUnsafeCastCheckerExpectations:
* Source/WebKit/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginAnnotation.mm:
(WebKit::PDFPluginAnnotation::updateGeometry):
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:
(WebKit::PDFPluginChoiceAnnotation::updateGeometry):
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginPasswordForm.mm:
(WebKit::PDFPluginPasswordForm::createAnnotationElement):
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:
(WebKit::PDFPluginTextAnnotation::createAnnotationElement):
(WebKit::PDFPluginTextAnnotation::updateGeometry):

Canonical link: https://commits.webkit.org/287891@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list