[webkit-changes] [WebKit/WebKit] 331b57: REGRESSION(286869 at main): text in heading of GitHub...

Alan Baradlay noreply at github.com
Mon Dec 16 09:15:23 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 331b574e779ca578c3276b8a91c7144cde5a2511
      https://github.com/WebKit/WebKit/commit/331b574e779ca578c3276b8a91c7144cde5a2511
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-12-16 (Mon, 16 Dec 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/contain-layout-baseline-005.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/contain-layout-baseline-006-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/contain-layout-baseline-006-ref.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/contain-layout-baseline-006.html
    M Source/WebCore/rendering/RenderBlock.cpp
    M Source/WebCore/rendering/RenderBlockFlow.cpp
    M Source/WebCore/rendering/RenderBox.h

  Log Message:
  -----------
  REGRESSION(286869 at main): text in heading of GitHub PR description is not vertically aligned
https://bugs.webkit.org/show_bug.cgi?id=284731
<rdar://141271678>

Reviewed by Antti Koivisto.

Let's not try to synthesize a block-level box's baseline when it has layout containment. Such boxes behave as if they had no baseline.
This behavior matches both Firefox and Chrome.

* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/contain-layout-baseline-006-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/contain-layout-baseline-006-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/contain-layout-baseline-006.html: Added.
* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::RenderBlock::firstLineBaseline const):
(WebCore::RenderBlock::lastLineBaseline const):
(WebCore::RenderBlock::inlineBlockBaseline const):
* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::inlineBlockBaseline const):
* Source/WebCore/rendering/RenderBox.h:
(WebCore::RenderBox::firstLineBaseline const):
(WebCore::RenderBox::lastLineBaseline const):
(WebCore::RenderBox::inlineBlockBaseline const):

Canonical link: https://commits.webkit.org/287888@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list