[webkit-changes] [WebKit/WebKit] 657297: [WebDriver][socket] true is set even if the accept...

[Haruhisa SHIN]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6572975a5c6e7510bac51d9d8ed76e85becf7cfb
      https://github.com/WebKit/WebKit/commit/6572975a5c6e7510bac51d9d8ed76e85becf7cfb
  Author: Haruhisa SHIN <haruhisa.shin at open-tec.co.jp>
  Date:   2024-12-16 (Mon, 16 Dec 2024)

  Changed paths:
    M Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorSocket.cpp

  Log Message:
  -----------
  [WebDriver][socket] true is set even if the acceptInsecureCerts is false
https://bugs.webkit.org/show_bug.cgi?id=284738

Reviewed by Fujii Hironori.

There was a mistake in https://commits.webkit.org/287707@main

The JSONObject::getBoolean() returns std::optional<bool>, not bool.
Since the getBoolean() indicates that a value was obtained,
the if statement will succeed even if its value is false.

This change uses value_or() to set the correct value.
Following the W3C recommendation, the default value is false.

* Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorSocket.cpp:
(Inspector::RemoteInspector::startAutomationSession):

Canonical link: https://commits.webkit.org/287873@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications