[webkit-changes] [WebKit/WebKit] cda20f: Textarea incorrectly reserves space for overlay sc...

[Luke Warlow]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cda20f66eecb111c71be0960b981e596473e889f
      https://github.com/WebKit/WebKit/commit/cda20f66eecb111c71be0960b981e596473e889f
  Author: Luke Warlow <lwarlow at igalia.com>
  Date:   2024-12-14 (Sat, 14 Dec 2024)

  Changed paths:
    A LayoutTests/fast/scrolling/mac/scrollbars/overlay-scrollbar-textarea-cols-size-expected.txt
    A LayoutTests/fast/scrolling/mac/scrollbars/overlay-scrollbar-textarea-cols-size.html
    A LayoutTests/fast/scrolling/mac/scrollbars/overlay-scrollbar-textarea-rows-size-expected.txt
    A LayoutTests/fast/scrolling/mac/scrollbars/overlay-scrollbar-textarea-rows-size.html
    M Source/WebCore/platform/ScrollTypes.h
    M Source/WebCore/platform/ScrollbarTheme.h
    M Source/WebCore/platform/adwaita/ScrollbarThemeAdwaita.cpp
    M Source/WebCore/platform/adwaita/ScrollbarThemeAdwaita.h
    M Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp
    M Source/WebCore/platform/gtk/ScrollbarThemeGtk.h
    M Source/WebCore/platform/ios/ScrollbarThemeIOS.h
    M Source/WebCore/platform/ios/ScrollbarThemeIOS.mm
    M Source/WebCore/platform/mac/ScrollbarThemeMac.h
    M Source/WebCore/platform/mac/ScrollbarThemeMac.mm
    M Source/WebCore/platform/mock/ScrollbarThemeMock.cpp
    M Source/WebCore/platform/mock/ScrollbarThemeMock.h
    M Source/WebCore/platform/playstation/ScrollbarThemePlayStation.cpp
    M Source/WebCore/platform/playstation/ScrollbarThemePlayStation.h
    M Source/WebCore/rendering/RenderBox.h
    M Source/WebCore/rendering/RenderScrollbarTheme.h
    M Source/WebCore/rendering/RenderTextControl.cpp

  Log Message:
  -----------
  Textarea incorrectly reserves space for overlay scrollbar
https://bugs.webkit.org/show_bug.cgi?id=275114

Reviewed by Simon Fraser.

Check the ScrollbarTheme::usesOverlayScrollbar in the various ScrollbarTheme's scrollbarThickness method.
Update RenderTextControl to tell scrollbarThickness to ignore overlay scrollbar sizing.

This aligns WebKit with Firefox.

* LayoutTests/fast/scrolling/mac/scrollbars/overlay-scrollbar-textarea-cols-size-expected.txt: Added.
* LayoutTests/fast/scrolling/mac/scrollbars/overlay-scrollbar-textarea-cols-size.html: Added.
* LayoutTests/fast/scrolling/mac/scrollbars/overlay-scrollbar-textarea-rows-size-expected.txt: Added.
* LayoutTests/fast/scrolling/mac/scrollbars/overlay-scrollbar-textarea-rows-size.html: Added.
* Source/WebCore/platform/ScrollTypes.h:
* Source/WebCore/platform/ScrollbarTheme.h:
(WebCore::ScrollbarTheme::scrollbarThickness):
* Source/WebCore/platform/adwaita/ScrollbarThemeAdwaita.cpp:
(WebCore::ScrollbarThemeAdwaita::scrollbarThickness):
* Source/WebCore/platform/adwaita/ScrollbarThemeAdwaita.h:
* Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp:
(WebCore::ScrollbarThemeGtk::scrollbarThickness):
* Source/WebCore/platform/gtk/ScrollbarThemeGtk.h:
* Source/WebCore/platform/ios/ScrollbarThemeIOS.h:
* Source/WebCore/platform/ios/ScrollbarThemeIOS.mm:
(WebCore::ScrollbarThemeIOS::scrollbarThickness):
* Source/WebCore/platform/mac/ScrollbarThemeMac.h:
* Source/WebCore/platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::scrollbarThickness):
* Source/WebCore/platform/mock/ScrollbarThemeMock.cpp:
(WebCore::ScrollbarThemeMock::scrollbarThickness):
* Source/WebCore/platform/mock/ScrollbarThemeMock.h:
* Source/WebCore/platform/playstation/ScrollbarThemePlayStation.cpp:
(WebCore::ScrollbarThemePlayStation::scrollbarThickness):
* Source/WebCore/platform/playstation/ScrollbarThemePlayStation.h:
* Source/WebCore/rendering/RenderBox.h:
* Source/WebCore/rendering/RenderScrollbarTheme.h:
* Source/WebCore/rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::scrollbarThickness const):

Canonical link: https://commits.webkit.org/287837@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications