[webkit-changes] [WebKit/WebKit] 005288: REGRESSION(287648 at main): [macOS wk2 Debug] importe...

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 005288f3b10c91a1f1bf8509ee0281148667e063
      https://github.com/WebKit/WebKit/commit/005288f3b10c91a1f1bf8509ee0281148667e063
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2024-12-13 (Fri, 13 Dec 2024)

  Changed paths:
    M LayoutTests/platform/mac-wk2/TestExpectations
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/page/LocalFrameView.cpp
    M Source/WebCore/page/LocalFrameView.h
    M Source/WebCore/page/LocalFrameViewLayoutContext.cpp
    M Source/WebCore/page/LocalFrameViewLayoutContext.h
    M Source/WebCore/rendering/RenderLayer.cpp
    M Source/WebCore/rendering/RenderLayer.h

  Log Message:
  -----------
  REGRESSION(287648 at main): [macOS wk2 Debug] imported/blink/fast/hidpi/border-background-align.html is a constant crash (flaky in EWS)
https://bugs.webkit.org/show_bug.cgi?id=284493
rdar://141315960

Reviewed by Alan Baradlay.

This is similar to 287607 at main, but for `updateLayerPositionsAfterStyleChange()` instead of
`updateLayerPositionsAfterLayout()`.

We move `updateCompositingLayersAfterStyleChange()` from LocalFrameView to LocalFrameViewLayoutContext
(along the lines of 287568 at main), and add a check for a change in repaint rect environment.

* LayoutTests/platform/mac-wk2/TestExpectations:
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::resolveStyle):
* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::LocalFrameView::updateCompositingLayersAfterStyleChange): Deleted.
* Source/WebCore/page/LocalFrameView.h:
* Source/WebCore/page/LocalFrameViewLayoutContext.cpp:
(WebCore::LocalFrameViewLayoutContext::updateCompositingLayersAfterStyleChange):
* Source/WebCore/page/LocalFrameViewLayoutContext.h:
* Source/WebCore/rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositionsAfterStyleChange):
* Source/WebCore/rendering/RenderLayer.h:

Canonical link: https://commits.webkit.org/287832@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications