[webkit-changes] [WebKit/WebKit] 17a846: Replace LocalFrame::hasHadUserInteraction() with D...

[Brady Eidson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 17a84631900e9432c83d9bfd956965210ffb8299
      https://github.com/WebKit/WebKit/commit/17a84631900e9432c83d9bfd956965210ffb8299
  Author: Brady Eidson <beidson at apple.com>
  Date:   2024-12-13 (Fri, 13 Dec 2024)

  Changed paths:
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/dom/Element.cpp
    M Source/WebCore/dom/UserGestureIndicator.cpp
    M Source/WebCore/page/LocalDOMWindow.cpp
    M Source/WebCore/page/LocalFrame.h

  Log Message:
  -----------
  Replace LocalFrame::hasHadUserInteraction() with Document::hasHadUserInteraction()
rdar://141466008
https://bugs.webkit.org/show_bug.cgi?id=284673

Reviewed by Alex Christensen.

Every place that checked this flag on LocalFrame could've checked it on that Frame's Document instead.

I think it's possible all of these checks can be folded into a single data member of the top document sync data,
but removing the LocalFrame copy is a standalone step in that direction.

* Source/WebCore/dom/Document.cpp:
(WebCore::Document::isNavigationBlockedByThirdPartyIFrameRedirectBlocking):
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::focus):
* Source/WebCore/dom/UserGestureIndicator.cpp:
* Source/WebCore/page/LocalDOMWindow.cpp:
(WebCore::LocalDOMWindow::focus):
* Source/WebCore/page/LocalFrame.h:

Canonical link: https://commits.webkit.org/287829@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications