[webkit-changes] [WebKit/WebKit] a733f9: [Screen Time Refactoring] iOS support for URL dona...

Jessica Cheung noreply at github.com
Fri Dec 13 12:38:04 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a733f9fa61f55450eac6e28714112c5317bf8d62
      https://github.com/WebKit/WebKit/commit/a733f9fa61f55450eac6e28714112c5317bf8d62
  Author: Jessica Cheung <jcheung23 at apple.com>
  Date:   2024-12-13 (Fri, 13 Dec 2024)

  Changed paths:
    M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
    M Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.h
    M Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.mm
    M Source/WebKit/UIProcess/ios/PageClientImplIOS.mm
    M Source/WebKit/UIProcess/mac/PageClientImplMac.h
    M Source/WebKit/UIProcess/mac/PageClientImplMac.mm

  Log Message:
  -----------
  [Screen Time Refactoring] iOS support for URL donations
https://bugs.webkit.org/show_bug.cgi?id=284316
rdar://140438859

Reviewed by Aditya Keerthi and Richard Robinson.

Added Screen Time shield to show for iOS.
Mirrored macOS Screen Time donation for loaded pages, but for iOS as well.
Changed screenTimeWebpageControllerBlockedKVOContext to use
&screenTimeWebpageControllerBlockedKVOContext.
Consolidated `installScreenTimeWebpageController` and `updateScreenTimeWebpageControllerURL`
to be on `PageClientImplCocoa` since the logic is now the same for macOS and iOS.

* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _installScreenTimeWebpageController]):
(-[WKWebView _uninstallScreenTimeWebpageController]):
* Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.h:
* Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.mm:
(WebKit::PageClientImplCocoa::installScreenTimeWebpageController):
(WebKit::PageClientImplCocoa::updateScreenTimeWebpageControllerURL):
* Source/WebKit/UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::didCommitLoadForMainFrame):
* Source/WebKit/UIProcess/mac/PageClientImplMac.h:
* Source/WebKit/UIProcess/mac/PageClientImplMac.mm:
(WebKit::PageClientImpl::installScreenTimeWebpageController): Deleted.
(WebKit::updateScreenTimeWebpageControllerURL): Deleted.

Canonical link: https://commits.webkit.org/287810@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list