[webkit-changes] [WebKit/WebKit] 7cc1f1: Add null checks in ResourceLoader::shouldAllowReso...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7cc1f1e83a156aa767b2ec9962d71f4a4978defc
      https://github.com/WebKit/WebKit/commit/7cc1f1e83a156aa767b2ec9962d71f4a4978defc
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2024-12-13 (Fri, 13 Dec 2024)

  Changed paths:
    M Source/WebCore/loader/ResourceLoader.cpp

  Log Message:
  -----------
  Add null checks in ResourceLoader::shouldAllowResourceToAskForCredentials
https://bugs.webkit.org/show_bug.cgi?id=284647
rdar://141399532

Reviewed by Charlie Wolfe.

Crash logs indicate we can dereference null in this function, particularly
during teardown when site isolation is enabled, which has increased recently
with the recent enablement of the WebProcessCache when site isolation is enabled
which required some interesting new teardown code to be written.  If there is
no frame or the frame has no document, it is safe to assume we should not be
asking for credentials.

* Source/WebCore/loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::shouldAllowResourceToAskForCredentials const):

Canonical link: https://commits.webkit.org/287808@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications