[webkit-changes] [WebKit/WebKit] 3de1a3: UnifiedPDF: Compositing spends time copying page p...

Kimmo Kinnunen noreply at github.com
Fri Dec 13 11:45:17 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3de1a3dce6ef41f08750269ba73d1466d451f6f9
      https://github.com/WebKit/WebKit/commit/3de1a3dce6ef41f08750269ba73d1466d451f6f9
  Author: Kimmo Kinnunen <kkinnunen at apple.com>
  Date:   2024-12-13 (Fri, 13 Dec 2024)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.h
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.mm

  Log Message:
  -----------
  UnifiedPDF: Compositing spends time copying page preview bitmaps to GPUP
https://bugs.webkit.org/show_bug.cgi?id=284461
rdar://141281826

Reviewed by Simon Fraser.

Use NativeImages instead of ImageBuffers to paint the PDF page preview
layer contents. NativeImages are slightly more performant and using
them is consistent with the other bitmap uses.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.mm:
(WebKit::renderPDFPagePreview):
(WebKit::AsyncPDFRenderer::generatePreviewImageForPage):
(WebKit::AsyncPDFRenderer::didCompletePagePreviewRender):
(WebKit::AsyncPDFRenderer::renderInfoForTile const):
(WebKit::AsyncPDFRenderer::paintTilesForPage):
(WebKit::AsyncPDFRenderer::paintPagePreview):
(WebKit::AsyncPDFRenderer::paintPagePreviewOnWorkQueue): Deleted.
(WebKit::AsyncPDFRenderer::previewImageForPage const): Deleted.
(WebKit::AsyncPDFRenderer::paintPDFPageIntoBuffer): Deleted.

Canonical link: https://commits.webkit.org/287804@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list