[webkit-changes] [WebKit/WebKit] d97fff: [iOS] grid-aspect-ratio-align-items-center.html co...

[Sammy Gill]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d97fff0f2eeb1bb420ac14a607adb3e943f26cbd
      https://github.com/WebKit/WebKit/commit/d97fff0f2eeb1bb420ac14a607adb3e943f26cbd
  Author: Sammy Gill <sammy.gill at apple.com>
  Date:   2024-12-13 (Fri, 13 Dec 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/grid-aspect-ratio-align-items-center.html
    M LayoutTests/platform/ios/TestExpectations

  Log Message:
  -----------
  [iOS] grid-aspect-ratio-align-items-center.html constantly failing (image).
https://bugs.webkit.org/show_bug.cgi?id=283995
rdar://140870687

Reviewed by Alan Baradlay.

In 286367 at main we added a test as part of the bug fix, but it seems like
it has always been failing on iOS since it was added. After taking a
look at the image diff, it seems like the underlying bug that was
addressed in the previous patch is still fixed on iOS, however there is
some sort of discrepancy with the linear-gradient that was used.

This patch slightly modifies the test so that it still verifies that the
underlying bug in the initial patch is fixed and also passes more consistenly
on different platforms. This is done by placing two abs pos divs at the
top and bottom of the div. This then leaves empty space in the middle
which the grid item is supposed to take up. Without the fix in 286367 at main
the significant amount of extra space causes the test to fail.

* LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/grid-aspect-ratio-align-items-center.html:
* LayoutTests/platform/ios/TestExpectations:

Canonical link: https://commits.webkit.org/287802@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications