[webkit-changes] [WebKit/WebKit] f84a7c: [UnifiedPDF] [iOS] Selection view should scroll wi...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f84a7c018b4cecbe2cc388b9ef17a92d6ca800d7
      https://github.com/WebKit/WebKit/commit/f84a7c018b4cecbe2cc388b9ef17a92d6ca800d7
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2024-12-12 (Thu, 12 Dec 2024)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFPresentationController.h
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFScrollingPresentationController.h
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFScrollingPresentationController.mm
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

  Log Message:
  -----------
  [UnifiedPDF] [iOS] Selection view should scroll with plugin contents
https://bugs.webkit.org/show_bug.cgi?id=284599
rdar://141324767

Reviewed by Abrar Rahman Protyasha.

Make native text selection views scroll along with PDF content on iOS, by making UIKit's native
selection UI cover `PDFScrollingPresentationController::m_contentsLayer`.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFPresentationController.h:
(WebKit::PDFPresentationController::contentsLayerIdentifier const):

Add an override point to return the platform layer ID of the PDF content layer.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFScrollingPresentationController.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFScrollingPresentationController.mm:
(WebKit::PDFScrollingPresentationController::contentsLayerIdentifier const):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::platformPopulateEditorStateIfNeeded const):

Canonical link: https://commits.webkit.org/287781@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications