[webkit-changes] [WebKit/WebKit] e2eb78: [SwiftUI] Support presenting JavaScript dialogs

Richard Robinson noreply at github.com
Thu Dec 12 17:14:35 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e2eb78275e5ee653431c9dedd94138f7c6efe03b
      https://github.com/WebKit/WebKit/commit/e2eb78275e5ee653431c9dedd94138f7c6efe03b
  Author: Richard Robinson <richard_robinson2 at apple.com>
  Date:   2024-12-12 (Thu, 12 Dec 2024)

  Changed paths:
    A Source/WebKit/UIProcess/API/Swift/WKUIDelegateAdapter.swift
    A Source/WebKit/UIProcess/API/Swift/WebPage+DialogPresenting.swift
    M Source/WebKit/UIProcess/API/Swift/WebPage.swift
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    M Tools/SwiftBrowser/Source/BrowserViewModel.swift
    M Tools/SwiftBrowser/Source/ContentView.swift

  Log Message:
  -----------
  [SwiftUI] Support presenting JavaScript dialogs
https://bugs.webkit.org/show_bug.cgi?id=284402
rdar://141108805

Reviewed by Wenson Hsieh.

Add the ability to support JavaScript alerts, confirmation prompts, text input prompts, and file input.

* Source/WebKit/UIProcess/API/Swift/WKUIDelegateAdapter.swift: Added.
(WKUIDelegateAdapter.webView(_:runJavaScriptAlertPanelWithMessage:initiatedByFrame:)):
(WKUIDelegateAdapter.webView(_:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:)):
(WKUIDelegateAdapter.webView(_:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:)):
(WKUIDelegateAdapter.webView(_:runOpenPanelWith:initiatedByFrame:)):
* Source/WebKit/UIProcess/API/Swift/WebPage+DialogPresenting.swift: Added.
(DialogPresenting.handleJavaScriptAlert(_:initiatedBy:)):
(DialogPresenting.handleJavaScriptConfirm(_:initiatedBy:)):
(DialogPresenting.handleJavaScriptPrompt(_:defaultText:initiatedBy:)):
(DialogPresenting.handleFileInputPrompt(_:initiatedBy:)):
* Source/WebKit/UIProcess/API/Swift/WebPage.swift:
(WebPage_v0.backingWebView):
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Tools/SwiftBrowser/Source/BrowserViewModel.swift:
(hash(into:)):
(owner):
(handleJavaScriptAlert(_:initiatedBy:)):
(handleJavaScriptConfirm(_:initiatedBy:)):
(handleJavaScriptPrompt(_:defaultText:initiatedBy:)):
(handleFileInputPrompt(_:initiatedBy:)):
(BrowserViewModel.currentDialog):
(BrowserViewModel.currentFilePicker):
(BrowserViewModel.didImportFiles(_:any:)):
* Tools/SwiftBrowser/Source/ContentView.swift:
(DialogActionsView.body):
(DialogMessageView.body):
(ContentView.body):

Canonical link: https://commits.webkit.org/287773@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list