[webkit-changes] [WebKit/WebKit] 488d06: Handle stack returns for IPInt calls

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 488d06c565f4b68c31ce57e602f62d32f2a48943
      https://github.com/WebKit/WebKit/commit/488d06c565f4b68c31ce57e602f62d32f2a48943
  Author: Daniel Liu <daniel_liu4 at apple.com>
  Date:   2024-12-12 (Thu, 12 Dec 2024)

  Changed paths:
    A JSTests/wasm/ipint-tests/ipint-test-call-stack-ret.js
    M Source/JavaScriptCore/llint/InPlaceInterpreter.asm
    M Source/JavaScriptCore/llint/InPlaceInterpreter.h
    M Source/JavaScriptCore/llint/InPlaceInterpreter32_64.asm
    M Source/JavaScriptCore/llint/InPlaceInterpreter64.asm
    M Source/JavaScriptCore/wasm/WasmIPIntGenerator.cpp
    M Source/JavaScriptCore/wasm/WasmIPIntGenerator.h

  Log Message:
  -----------
  Handle stack returns for IPInt calls
https://bugs.webkit.org/show_bug.cgi?id=284484
rdar://141309596

Reviewed by Yusuke Suzuki.

IPInt previously did not handle stack return values when performing a call out of IPInt.

* JSTests/wasm/ipint-tests/ipint-test-call-stack-ret.js: Added.
(from.string_appeared_here.import.as.assert.from.string_appeared_here.let.wat.module.func.callee.param.i32.result.i32.result.i32.result.i32.result.i32.result.i32.result.i32.result.i32.result.i32.result.i32.result.i32.i32.const.1.i32.const.2.i32.const.3.i32.const.4.i32.const.5.i32.const.6.i32.const.7.i32.const.8.i32.const.9.i32.const.10.return.func.export.string_appeared_here.result.i32.i32.const.1.call.callee.i32.add.i32.add.i32.add.i32.add.i32.add.i32.add.i32.add.i32.add.i32.add.return.async test):
* Source/JavaScriptCore/llint/InPlaceInterpreter.asm:
* Source/JavaScriptCore/llint/InPlaceInterpreter.h:
* Source/JavaScriptCore/llint/InPlaceInterpreter64.asm:
* Source/JavaScriptCore/wasm/WasmIPIntGenerator.cpp:
(JSC::Wasm::IPIntGenerator::addCallCommonData):
(JSC::Wasm::IPIntGenerator::addCall):
(JSC::Wasm::IPIntGenerator::addCallIndirect):
(JSC::Wasm::IPIntGenerator::addCallRef):
* Source/JavaScriptCore/wasm/WasmIPIntGenerator.h:

Canonical link: https://commits.webkit.org/287763@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications