[webkit-changes] [WebKit/WebKit] af27e9: Thread safety in Observables visitAdditionalChildr...

[Marais Rossouw]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: af27e9ed9ef2f1e26eea8a4541f36ff7c39cb6d0
      https://github.com/WebKit/WebKit/commit/af27e9ed9ef2f1e26eea8a4541f36ff7c39cb6d0
  Author: Marais Rossouw <me at marais.co>
  Date:   2024-12-12 (Thu, 12 Dec 2024)

  Changed paths:
    M Source/WebCore/dom/InternalObserverDrop.cpp
    M Source/WebCore/dom/InternalObserverEvery.cpp
    M Source/WebCore/dom/InternalObserverFilter.cpp
    M Source/WebCore/dom/InternalObserverFind.cpp
    M Source/WebCore/dom/InternalObserverFirst.cpp
    M Source/WebCore/dom/InternalObserverForEach.cpp
    M Source/WebCore/dom/InternalObserverInspect.cpp
    M Source/WebCore/dom/InternalObserverLast.cpp
    M Source/WebCore/dom/InternalObserverReduce.cpp
    M Source/WebCore/dom/InternalObserverSome.cpp
    M Source/WebCore/dom/InternalObserverTake.cpp

  Log Message:
  -----------
  Thread safety in Observables visitAdditionalChildren methods
https://bugs.webkit.org/show_bug.cgi?id=284500

Reviewed by Ryosuke Niwa and Chris Dumez.

visitAdditionalChildren should not ref/deref objects that are
single-threaded ref counted since this function gets called
concurrently to the main thread.

* Source/WebCore/dom/InternalObserverDrop.cpp:
* Source/WebCore/dom/InternalObserverEvery.cpp:
* Source/WebCore/dom/InternalObserverFilter.cpp:
* Source/WebCore/dom/InternalObserverFind.cpp:
* Source/WebCore/dom/InternalObserverFirst.cpp:
* Source/WebCore/dom/InternalObserverForEach.cpp:
* Source/WebCore/dom/InternalObserverInspect.cpp:
* Source/WebCore/dom/InternalObserverLast.cpp:
* Source/WebCore/dom/InternalObserverReduce.cpp:
* Source/WebCore/dom/InternalObserverSome.cpp:
* Source/WebCore/dom/InternalObserverTake.cpp:

Canonical link: https://commits.webkit.org/287733@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications