[webkit-changes] [WebKit/WebKit] c3d57c: Remove HAVE_OS_DARK_MODE_SUPPORT

Tim Nguyen noreply at github.com
Wed Dec 11 17:34:56 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c3d57c8fad33b07b852f4cd4cbc4cdfd892cbf91
      https://github.com/WebKit/WebKit/commit/c3d57c8fad33b07b852f4cd4cbc4cdfd892cbf91
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2024-12-11 (Wed, 11 Dec 2024)

  Changed paths:
    M Source/WTF/wtf/PlatformHave.h
    M Source/WebCore/CMakeLists.txt
    M Source/WebCore/PlatformGTK.cmake
    M Source/WebCore/PlatformMac.cmake
    M Source/WebCore/PlatformWPE.cmake
    M Source/WebCore/css/CSSValueKeywords.in
    M Source/WebCore/css/html.css
    M Source/WebCore/inspector/InspectorInstrumentation.cpp
    M Source/WebCore/inspector/InspectorInstrumentation.h
    M Source/WebCore/inspector/agents/InspectorPageAgent.cpp
    M Source/WebCore/inspector/agents/InspectorPageAgent.h
    M Source/WebCore/page/LocalFrameView.cpp
    M Source/WebCore/page/Page.cpp
    M Source/WebCore/platform/graphics/GraphicsContext.h
    M Source/WebCore/platform/graphics/GraphicsContextState.cpp
    M Source/WebCore/platform/graphics/GraphicsContextState.h
    M Source/WebCore/rendering/TextPaintStyle.cpp
    M Source/WebCore/rendering/TextPaintStyle.h
    M Source/WebCore/rendering/adwaita/RenderThemeAdwaita.cpp
    M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
    M Source/cmake/OptionsGTK.cmake
    M Source/cmake/OptionsWPE.cmake
    M Source/cmake/OptionsWin.cmake
    M Tools/TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/CopyRTF.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteRTFD.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewUnderPageBackgroundColor.mm
    M Tools/TestWebKitAPI/cocoa/TestWKWebView.mm

  Log Message:
  -----------
  Remove HAVE_OS_DARK_MODE_SUPPORT
https://bugs.webkit.org/show_bug.cgi?id=284482
rdar://141309130

Reviewed by Aditya Keerthi.

This is enabled everywhere. Remove it so code becomes easier to read.

* Source/WTF/wtf/PlatformHave.h:
* Source/WebCore/CMakeLists.txt:
* Source/WebCore/PlatformGTK.cmake:
* Source/WebCore/PlatformMac.cmake:
* Source/WebCore/PlatformWPE.cmake:
* Source/WebCore/css/CSSValueKeywords.in:
* Source/WebCore/css/html.css:
(@namespace "http://www.w3.org/1999/xhtml";):
(#if defined(WTF_PLATFORM_IOS_FAMILY) && WTF_PLATFORM_IOS_FAMILY):
(#endif):
(#endif // defined(ENABLE_INPUT_TYPE_COLOR) && ENABLE_INPUT_TYPE_COLOR):
(#if defined(HAVE_OS_DARK_MODE_SUPPORT) && HAVE_OS_DARK_MODE_SUPPORT): Deleted.
* Source/WebCore/inspector/InspectorInstrumentation.cpp:
* Source/WebCore/inspector/InspectorInstrumentation.h:
* Source/WebCore/inspector/agents/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::overridePrefersColorScheme):
(WebCore::InspectorPageAgent::defaultUserPreferencesDidChange):
* Source/WebCore/inspector/agents/InspectorPageAgent.h:
* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::LocalFrameView::updateBackgroundRecursively):
* Source/WebCore/page/Page.cpp:
(WebCore::Page::setUseDarkAppearanceOverride):
* Source/WebCore/platform/graphics/GraphicsContext.h:
(WebCore::GraphicsContext::setUseDarkAppearance):
* Source/WebCore/platform/graphics/GraphicsContextState.cpp:
(WebCore::GraphicsContextState::mergeSingleChange):
(WebCore::GraphicsContextState::mergeAllChanges):
(WebCore::stateChangeName):
(WebCore::GraphicsContextState::dump const):
* Source/WebCore/platform/graphics/GraphicsContextState.h:
(WebCore::GraphicsContextState::setUseDarkAppearance):
* Source/WebCore/rendering/TextPaintStyle.cpp:
(WebCore::TextPaintStyle::operator== const):
(WebCore::computeTextPaintStyle):
(WebCore::updateGraphicsContext):
* Source/WebCore/rendering/TextPaintStyle.h:
* Source/WebCore/rendering/adwaita/RenderThemeAdwaita.cpp:
(WebCore::RenderThemeAdwaita::systemColor const):
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:
* Source/cmake/OptionsWin.cmake:
* Tools/TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/CopyRTF.mm:
(TEST(CopyRTF, StripsDefaultTextColorOfDarkContent)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteRTFD.mm:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewUnderPageBackgroundColor.mm:
(defaultBackgroundColor):
* Tools/TestWebKitAPI/cocoa/TestWKWebView.mm:
(-[TestWKWebView forceDarkMode]):

Canonical link: https://commits.webkit.org/287712@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list