[webkit-changes] [WebKit/WebKit] ee5d45: Offline asm local labels should include file and l...

[Keith Miller]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ee5d453563ae7cb6f540b560d76900f5b9fffbbd
      https://github.com/WebKit/WebKit/commit/ee5d453563ae7cb6f540b560d76900f5b9fffbbd
  Author: Keith Miller <keith_miller at apple.com>
  Date:   2024-12-11 (Wed, 11 Dec 2024)

  Changed paths:
    M Source/JavaScriptCore/offlineasm/arm.rb
    M Source/JavaScriptCore/offlineasm/arm64.rb
    M Source/JavaScriptCore/offlineasm/ast.rb
    M Source/JavaScriptCore/offlineasm/backends.rb
    M Source/JavaScriptCore/offlineasm/parser.rb
    M Source/JavaScriptCore/offlineasm/riscv64.rb
    M Source/JavaScriptCore/offlineasm/transform.rb
    M Source/JavaScriptCore/offlineasm/x86.rb

  Log Message:
  -----------
  Offline asm local labels should include file and line numbers
https://bugs.webkit.org/show_bug.cgi?id=284407
rdar://141245505

Reviewed by Yusuke Suzuki.

Add the file and line number for local labels to the label string. Now that we have alt_entry
a lot of the labels we spew out are hard to associate to a particular opcode. This change makes
it marginally easier to figure out what area of asm a crash in LLInt/IPInt is near.

In the future we should probably have a pragma to add the current opcode to local
labels.

Also, canonicalize LocalLabelReferences to LocalLabelReferences so that they
point to the underlying LocalLabel.

* Source/JavaScriptCore/offlineasm/arm.rb:
* Source/JavaScriptCore/offlineasm/arm64.rb:
* Source/JavaScriptCore/offlineasm/ast.rb:
* Source/JavaScriptCore/offlineasm/backends.rb:
* Source/JavaScriptCore/offlineasm/parser.rb:
* Source/JavaScriptCore/offlineasm/riscv64.rb:
* Source/JavaScriptCore/offlineasm/transform.rb:
* Source/JavaScriptCore/offlineasm/x86.rb:

Canonical link: https://commits.webkit.org/287710@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications