[webkit-changes] [WebKit/WebKit] fe03af: [WebDriver][socket] support capabilites.acceptInse...

Haruhisa SHIN noreply at github.com
Wed Dec 11 16:35:41 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fe03aff9178c035539ba05b2a7f97b24df765f6a
      https://github.com/WebKit/WebKit/commit/fe03aff9178c035539ba05b2a7f97b24df765f6a
  Author: Haruhisa SHIN <haruhisa.shin at open-tec.co.jp>
  Date:   2024-12-11 (Wed, 11 Dec 2024)

  Changed paths:
    M Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorSocket.cpp
    M Source/WebDriver/socket/SessionHostSocket.cpp
    M Source/WebKit/UIProcess/win/AutomationClientWin.cpp
    M Source/WebKit/UIProcess/win/AutomationClientWin.h

  Log Message:
  -----------
  [WebDriver][socket] support capabilites.acceptInsecureCerts
https://bugs.webkit.org/show_bug.cgi?id=284440

Reviewed by Fujii Hironori.

Before this change, win port WebDriver does not check the capabilities.

The W3C spec defines that self-signed or invalid certificates are
implicitly trusted if the value of `capabilities.acceptInsecureCerts`
is true.
https://www.w3.org/TR/webdriver2/#capabilities

For example, the tests in web-platform-tests use self-signed
certificates to start an http server.
Support for acceptInsecureCerts would be helpful to run those tests
over https.

* Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorSocket.cpp:
(Inspector::RemoteInspector::startAutomationSession):
* Source/WebDriver/socket/SessionHostSocket.cpp:
(WebDriver::SessionHost::startAutomationSession):
* Source/WebKit/UIProcess/win/AutomationClientWin.cpp:
(WebKit::AutomationSessionClient::AutomationSessionClient):
(WebKit::AutomationSessionClient::didReceiveAuthenticationChallenge):
(WebKit::AutomationSessionClient::requestNewPageWithOptions):
(WebKit::AutomationClient::requestAutomationSession):
* Source/WebKit/UIProcess/win/AutomationClientWin.h:

Canonical link: https://commits.webkit.org/287707@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list