[webkit-changes] [WebKit/WebKit] 561a9d: AtomicsIsLockFree should not be eliminated in DCE ...

Yijia Huang noreply at github.com
Wed Dec 11 08:38:44 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 561a9d8fc5e3e6526deb2b77923ed72786bbae99
      https://github.com/WebKit/WebKit/commit/561a9d8fc5e3e6526deb2b77923ed72786bbae99
  Author: Yijia Huang <hyjorc1 at gmail.com>
  Date:   2024-12-11 (Wed, 11 Dec 2024)

  Changed paths:
    A JSTests/stress/atomics-is-lock-free.js
    M Source/JavaScriptCore/dfg/DFGFixupPhase.cpp
    M Source/JavaScriptCore/dfg/DFGNodeType.h

  Log Message:
  -----------
  AtomicsIsLockFree should not be eliminated in DCE in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=284245
rdar://141233504

Reviewed by Keith Miller and Yusuke Suzuki.

AtomicsIsLockFree should be eliminated only if it has no side effects.
Here we do the elimination when its argument is not int32 use.

* JSTests/stress/atomics-is-lock-free.js: Added.
(f2):
(f1):
* Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
* Source/JavaScriptCore/dfg/DFGNodeType.h:

Canonical link: https://commits.webkit.org/287673@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list