[webkit-changes] [WebKit/WebKit] 00d61d: Implement CanvasRenderingContext2D letterSpacing/w...

[Rob Buis]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 00d61d715299f4a44a74385199c72f633cadee0d
      https://github.com/WebKit/WebKit/commit/00d61d715299f4a44a74385199c72f633cadee0d
  Author: Rob Buis <rbuis at igalia.com>
  Date:   2024-12-11 (Wed, 11 Dec 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/reset/2d.reset.state.letter_spacing-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/reset/2d.reset.state.word_spacing-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.drawing.style.absolute.spacing-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.drawing.style.font-relative.spacing-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.drawing.style.invalid.spacing-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.drawing.style.letterSpacing.change.font-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.drawing.style.letterSpacing.measure-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.drawing.style.nonfinite.spacing-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.drawing.style.wordSpacing.change.font-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.drawing.style.wordSpacing.measure-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/reset/2d.reset.state.letter_spacing-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/reset/2d.reset.state.letter_spacing.worker-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/reset/2d.reset.state.word_spacing-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/reset/2d.reset.state.word_spacing.worker-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.drawing.style.absolute.spacing-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.drawing.style.absolute.spacing.worker-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.drawing.style.font-relative.spacing-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.drawing.style.font-relative.spacing.worker-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.drawing.style.invalid.spacing-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.drawing.style.invalid.spacing.worker-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.drawing.style.letterSpacing.change.font-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.drawing.style.letterSpacing.change.font.worker-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.drawing.style.letterSpacing.measure-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.drawing.style.letterSpacing.measure.worker-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.drawing.style.nonfinite.spacing-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.drawing.style.nonfinite.spacing.worker-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.drawing.style.wordSpacing.change.font-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.drawing.style.wordSpacing.change.font.worker-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.drawing.style.wordSpacing.measure-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.drawing.style.wordSpacing.measure.worker-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/dom/idlharness.https_exclude=(Document_Window_HTML._)-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/dom/idlharness.worker-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/interfaces/html.idl
    M LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/dom/idlharness.https_exclude=(Document_Window_HTML._)-expected.txt
    M LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/dom/idlharness.worker-expected.txt
    M Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp
    M Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp
    M Source/WebCore/html/canvas/CanvasRenderingContext2DBase.h
    M Source/WebCore/html/canvas/CanvasTextDrawingStyles.idl
    M Source/WebCore/html/canvas/OffscreenCanvasRenderingContext2D.cpp

  Log Message:
  -----------
  Implement CanvasRenderingContext2D letterSpacing/wordSpacing
https://bugs.webkit.org/show_bug.cgi?id=283408

Reviewed by Said Abou-Hallawa.

Implement CanvasRenderingContext2D letterSpacing/wordSpacing [1, 2] by allowing to set these properties by string
on CanvasRenderingContext2D and as a computed Length on FontCascade. The CSS property parser is used to
convert the string value into the actual computed Length.

[1] https://html.spec.whatwg.org/multipage/canvas.html#dom-context-2d-letterspacing
[2] https://html.spec.whatwg.org/multipage/canvas.html#dom-context-2d-wordspacing

* LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/reset/2d.reset.state.letter_spacing-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/reset/2d.reset.state.word_spacing-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.drawing.style.absolute.spacing-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.drawing.style.font-relative.spacing-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.drawing.style.invalid.spacing-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.drawing.style.letterSpacing.change.font-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.drawing.style.letterSpacing.measure-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.drawing.style.nonfinite.spacing-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.drawing.style.wordSpacing.change.font-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.drawing.style.wordSpacing.measure-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/reset/2d.reset.state.letter_spacing-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/reset/2d.reset.state.letter_spacing.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/reset/2d.reset.state.word_spacing-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/reset/2d.reset.state.word_spacing.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.drawing.style.absolute.spacing-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.drawing.style.absolute.spacing.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.drawing.style.font-relative.spacing-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.drawing.style.font-relative.spacing.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.drawing.style.invalid.spacing-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.drawing.style.invalid.spacing.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.drawing.style.letterSpacing.change.font-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.drawing.style.letterSpacing.change.font.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.drawing.style.letterSpacing.measure-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.drawing.style.letterSpacing.measure.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.drawing.style.nonfinite.spacing-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.drawing.style.nonfinite.spacing.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.drawing.style.wordSpacing.change.font-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.drawing.style.wordSpacing.change.font.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.drawing.style.wordSpacing.measure-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.drawing.style.wordSpacing.measure.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/dom/idlharness.https_exclude=(Document_Window_HTML._)-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/dom/idlharness.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/interfaces/html.idl:
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/dom/idlharness.https_exclude=(Document_Window_HTML._)-expected.txt:
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/dom/idlharness.worker-expected.txt:
* Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setFontWithoutUpdatingStyle):
* Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp:
(WebCore::CanvasRenderingContext2DBase::State::State):
(WebCore::CanvasRenderingContext2DBase::setLetterSpacing):
(WebCore::CanvasRenderingContext2DBase::setWordSpacing):
* Source/WebCore/html/canvas/CanvasRenderingContext2DBase.h:
(WebCore::CanvasRenderingContext2DBase::letterSpacing const):
(WebCore::CanvasRenderingContext2DBase::wordSpacing const):
* Source/WebCore/html/canvas/CanvasTextDrawingStyles.idl:
* Source/WebCore/html/canvas/OffscreenCanvasRenderingContext2D.cpp:
(WebCore::OffscreenCanvasRenderingContext2D::setFont):

Canonical link: https://commits.webkit.org/287661@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications