[webkit-changes] [WebKit/WebKit] 51f1c2: TimerBase Crash under ~ScrollbarsControllerMac() w...

[Abrar Rahman Protyasha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 51f1c2bf89c70d3cfd6930874015f4d863eec9c0
      https://github.com/WebKit/WebKit/commit/51f1c2bf89c70d3cfd6930874015f4d863eec9c0
  Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
  Date:   2024-12-10 (Tue, 10 Dec 2024)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h

  Log Message:
  -----------
  TimerBase Crash under ~ScrollbarsControllerMac() when tearing down the PDFPlugin
https://bugs.webkit.org/show_bug.cgi?id=284412
rdar://141179510

Reviewed by Simon Fraser.

It is possible for the PDF plugin to be torn down off the main thread if
the stream fails during an incremental load. This leads to a release
assert in the TimerBase destructor which verifies that the current
thread was used to construct the timer.

We fix this by ensuring the plugin hops to the main thread during tear
down.

I was unable to write a test, though this crash likely reproduces when a
loading stream fail races against the user navigating away from a PDF
document.

* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h:

Canonical link: https://commits.webkit.org/287655@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications