[webkit-changes] [WebKit/WebKit] 29fa42: extractResolutionReport crash

[nmahendru]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 29fa42d04c1daa383de4e391562ba990ede0e50d
      https://github.com/WebKit/WebKit/commit/29fa42d04c1daa383de4e391562ba990ede0e50d
  Author: Nitin Mahendru <nitinmahendru at apple.com>
  Date:   2024-12-10 (Tue, 10 Dec 2024)

  Changed paths:
    M Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm

  Log Message:
  -----------
  extractResolutionReport crash
https://bugs.webkit.org/show_bug.cgi?id=284385
rdar://133489260

Reviewed by David Kilzer.

This is a speculative fix.

Add a retain to the resolution report to keep it live
long enough so that the dictionary construction gets a valid string from nw_xx apis

Also add a retain to the nw_path as it might also cause a future crash.

Also, add a null check for interfaces.get().

* Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(extractResolutionReport):

Canonical link: https://commits.webkit.org/287651@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications