[webkit-changes] [WebKit/WebKit] dbc582: [WebGPU] Dynamic offsets algorithm requires indice...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dbc582354bc67ac673bb343a49e41728c7706281
      https://github.com/WebKit/WebKit/commit/dbc582354bc67ac673bb343a49e41728c7706281
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-12-10 (Tue, 10 Dec 2024)

  Changed paths:
    A LayoutTests/fast/webgpu/nocrash/fuzz-284390-expected.txt
    A LayoutTests/fast/webgpu/nocrash/fuzz-284390.html
    M Source/WebGPU/WebGPU/BindGroup.mm

  Log Message:
  -----------
  [WebGPU] Dynamic offsets algorithm requires indices to be sorted
https://bugs.webkit.org/show_bug.cgi?id=284390
rdar://141199874

Reviewed by Dan Glastonbury.

The setBindGroup() algorithm, https://www.w3.org/TR/webgpu/#dom-gpubindingcommandsmixin-setbindgroup-index-bindgroup-dynamicoffsetsdata-dynamicoffsetsdatastart-dynamicoffsetsdatalength,
described in the specification states:

    For each GPUBindGroupEntry entry in bindGroup.[[entries]] ordered in increasing values of entry.binding:

we had not sorted these, i.e., they were not 'ordered in increasing values of entry.binding'

Fix this by sorting prior to BindGroup creation.

* LayoutTests/fast/webgpu/nocrash/fuzz-284390-expected.txt: Added.
* LayoutTests/fast/webgpu/nocrash/fuzz-284390.html: Added.
Add regression test.

* Source/WebGPU/WebGPU/BindGroup.mm:
(WebGPU::Device::createBindGroup):

Canonical link: https://commits.webkit.org/287645@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications