[webkit-changes] [WebKit/WebKit] 571556: imported/w3c/web-platform-tests/css/css-view-trans...

Simon Fraser noreply at github.com
Tue Dec 10 17:45:55 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5715565a4b6c459a2350fbcd90f71339e80d3866
      https://github.com/WebKit/WebKit/commit/5715565a4b6c459a2350fbcd90f71339e80d3866
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2024-12-10 (Tue, 10 Dec 2024)

  Changed paths:
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/dom/ViewTransition.cpp
    M Source/WebCore/dom/ViewTransition.h

  Log Message:
  -----------
  imported/w3c/web-platform-tests/css/css-view-transitions/no-white-flash-before-activation.html can time out
https://bugs.webkit.org/show_bug.cgi?id=284405
rdar://141243828

Reviewed by Matt Woodrow.

imported/w3c/web-platform-tests/css/css-view-transitions/no-white-flash-before-activation.html can time out in some cases
(seen on iOS and Intel bots on https://github.com/WebKit/WebKit/pull/22531).

This probably happens with that PR because nothing else triggers a rendering update after clearing rendering
suppression. So fix `Document::clearRenderingIsSuppressedForViewTransition()` to schedule a rendering update.

Also add more to the ViewTransition log channel.

* Source/WebCore/dom/Document.cpp:
(WebCore::Document::clearRenderingIsSuppressedForViewTransition):
(WebCore::Document::startViewTransition):
* Source/WebCore/dom/ViewTransition.cpp:
(WebCore::ViewTransition::createSamePage):
(WebCore::ViewTransition::skipViewTransition):
(WebCore::ViewTransition::callUpdateCallback):
(WebCore::operator<<):
* Source/WebCore/dom/ViewTransition.h:

Canonical link: https://commits.webkit.org/287643@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list