[webkit-changes] [WebKit/WebKit] 6813c5: Creating a WKWebExtension object from a zipped res...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6813c5273edcc62401788a171d96b07b875ba37a
      https://github.com/WebKit/WebKit/commit/6813c5273edcc62401788a171d96b07b875ba37a
  Author: Elijah Sawyers <esawyers at apple.com>
  Date:   2024-12-10 (Tue, 10 Dec 2024)

  Changed paths:
    M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm
    M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
    A Tools/TestWebKitAPI/Tests/WebKit/web-extension-with-parent-directory.zip
    A Tools/TestWebKitAPI/Tests/WebKit/web-extension-without-parent-directory.zip
    R Tools/TestWebKitAPI/Tests/WebKit/web-extension.zip
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtension.mm

  Log Message:
  -----------
  Creating a WKWebExtension object from a zipped resource URL can sometimes fail
https://bugs.webkit.org/show_bug.cgi?id=284331
rdar://141179462

Reviewed by Timothy Hatcher and Brian Weinstein.

This patch fixes a bug where creating a WKWebExtension object from a ZIP file
will fail if the contents of the zip are placed into a parent directory within
the temporary directory that's created.

The fix is to return the subdirectory of the temporary directory, if needed.

Also added a new test to cover this case.

* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm:
(WebKit::WebExtension::WebExtension):

Canonical link: https://commits.webkit.org/287639@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications