[webkit-changes] [WebKit/WebKit] 185612: Recompute event target when removed from changing ...

Ahmad Saleem noreply at github.com
Tue Dec 10 11:27:25 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 18561227325c21d4b156974983f0f44da1979a45
      https://github.com/WebKit/WebKit/commit/18561227325c21d4b156974983f0f44da1979a45
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2024-12-10 (Tue, 10 Dec 2024)

  Changed paths:
    A LayoutTests/editing/selection/caret-after-removing-node-expected.txt
    A LayoutTests/editing/selection/caret-after-removing-node.html
    M LayoutTests/platform/ios/TestExpectations
    M Source/WebCore/page/EventHandler.cpp

  Log Message:
  -----------
  Recompute event target when removed from changing selection

https://bugs.webkit.org/show_bug.cgi?id=284205
rdar://141080146

Reviewed by Wenson Hsieh.

Merge: https://chromium.googlesource.com/chromium/blink/+/f2696796968c131cf121536fd8c5f87d801d90a7

Changing selection by mouse click uses event target node to calculate position. This processing is
performed after event dispatch. When event handler removes event target node, selection isn't changed.

This patch changes this behavior to pass recomputing event target when it is removed for changing selection.

* Source/WebCore/page/EventHandler.cpp:
(WebCore::shouldRefetchEventTarget):
(WebCore::EventHandler::handleMousePressEvent):
* LayoutTests/editing/selection/caret-after-removing-node.html: Add Test Case
* LayoutTests/editing/selection/caret-after-removing-node-expected.txt: Add Test Case Expectation
* LayoutTests/platform/ios/TestExpectations: Skipped on iOS due to lack of MouseEvent

Canonical link: https://commits.webkit.org/287619@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list