[webkit-changes] [WebKit/WebKit] 4769bb: ASSERTION FAILED: !waiter->isOnList() in JavaScrip...

Yijia Huang noreply at github.com
Tue Dec 10 09:26:20 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4769bb5d4e997406785f52500158011441dc5f3a
      https://github.com/WebKit/WebKit/commit/4769bb5d4e997406785f52500158011441dc5f3a
  Author: Yijia Huang <yijia_huang at apple.com>
  Date:   2024-12-10 (Tue, 10 Dec 2024)

  Changed paths:
    A JSTests/stress/waitasync-wait-timeout-with-canceled-tickets.js
    M Source/JavaScriptCore/runtime/DeferredWorkTimer.cpp
    M Source/JavaScriptCore/runtime/WaiterListManager.cpp
    M Source/JavaScriptCore/runtime/WaiterListManager.h

  Log Message:
  -----------
  ASSERTION FAILED: !waiter->isOnList() in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=284244
rdar://141173936

Reviewed by Yusuke Suzuki.

This patch simplify the log in WaiterListManager::timeoutAsyncWaiter
since the DeferredWorkTimer::TicketData can be canceled at any time.

* JSTests/stress/waitasync-wait-timeout-with-canceled-tickets.js: Added.
(C0):
(i.let.handler.get target):
(i.f28):
* Source/JavaScriptCore/runtime/DeferredWorkTimer.cpp:
(JSC::DeferredWorkTimer::TicketData::cancel):
(JSC::DeferredWorkTimer::cancelPendingWork):
(JSC::DeferredWorkTimer::cancelPendingWorkSafe):
* Source/JavaScriptCore/runtime/WaiterListManager.cpp:
(JSC::WaiterListManager::timeoutAsyncWaiter):
* Source/JavaScriptCore/runtime/WaiterListManager.h:

Canonical link: https://commits.webkit.org/287611@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list