[webkit-changes] [WebKit/WebKit] 7f074e: [WebGPU] shouldn't call setSamplerState when argum...
mwyrzykowski
noreply at github.com
Tue Dec 10 06:33:51 PST 2024
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7f074e8bb9404fc5f88f884811c4ed2398b5ec11
https://github.com/WebKit/WebKit/commit/7f074e8bb9404fc5f88f884811c4ed2398b5ec11
Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
Date: 2024-12-10 (Tue, 10 Dec 2024)
Changed paths:
A LayoutTests/fast/webgpu/nocrash/fuzz-284326-expected.txt
A LayoutTests/fast/webgpu/nocrash/fuzz-284326.html
M Source/WebGPU/WebGPU/BindGroup.mm
Log Message:
-----------
[WebGPU] shouldn't call setSamplerState when argument buffer does not exist
https://bugs.webkit.org/show_bug.cgi?id=284326
radar://141179365
Reviewed by Tadeu Zagallo.
If an AB for a specific stage does not exist, it is illegal to call
setBuffer:, setTexture:, setSamplerState:, etc as no AB will be bound to the encoder.
* LayoutTests/fast/webgpu/nocrash/fuzz-284326-expected.txt: Added.
* LayoutTests/fast/webgpu/nocrash/fuzz-284326.html: Added.
Add regression test.
* Source/WebGPU/WebGPU/BindGroup.mm:
(WebGPU::BindGroup::rebindSamplersIfNeeded const):
Only call setSamplerState: when the AB exists.
Canonical link: https://commits.webkit.org/287601@main
To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications
More information about the webkit-changes
mailing list