[webkit-changes] [WebKit/WebKit] f23a15: Revert 287558 at main 287570 at main for causing linkage...

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f23a1541d7eb687530c9148eff2d7216210cc3b4
      https://github.com/WebKit/WebKit/commit/f23a1541d7eb687530c9148eff2d7216210cc3b4
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2024-12-09 (Mon, 09 Dec 2024)

  Changed paths:
    M LayoutTests/http/tests/cookies/resources/echo-http-and-dom-cookies-and-notify-done.py
    M LayoutTests/http/tests/cookies/resources/set-cookie-and-redirect-back.py
    R LayoutTests/http/tests/storageAccess/grant-with-prompt-under-general-third-party-cookie-blocking-with-partitioned-cookies.https-expected.txt
    R LayoutTests/http/tests/storageAccess/grant-with-prompt-under-general-third-party-cookie-blocking-with-partitioned-cookies.https.html
    M LayoutTests/platform/glib/TestExpectations
    M LayoutTests/platform/ios/TestExpectations
    M LayoutTests/platform/mac-wk2/TestExpectations
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WTF/wtf/PlatformHave.h
    M Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h
    M Source/WebCore/platform/network/NetworkStorageSession.cpp
    M Source/WebCore/platform/network/NetworkStorageSession.h
    M Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm
    M Source/WebKit/NetworkProcess/NetworkProcess.cpp
    M Source/WebKit/NetworkProcess/NetworkProcess.h
    M Source/WebKit/NetworkProcess/NetworkProcess.messages.in
    M Source/WebKit/NetworkProcess/NetworkSession.cpp
    M Source/WebKit/NetworkProcess/NetworkSession.h
    M Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm
    M Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
    M Source/WebKit/NetworkProcess/cocoa/NetworkTaskCocoa.h
    M Source/WebKit/NetworkProcess/cocoa/NetworkTaskCocoa.mm
    M Source/WebKit/NetworkProcess/cocoa/WebSocketTaskCocoa.mm
    M Source/WebKit/Shared/Cocoa/CoreIPCNSURLRequest.h
    M Source/WebKit/Shared/Cocoa/CoreIPCNSURLRequest.mm
    M Source/WebKit/Shared/Cocoa/CoreIPCNSURLRequest.serialization.in
    M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp

  Log Message:
  -----------
  Revert 287558 at main 287570 at main for causing linkage failures
https://bugs.webkit.org/show_bug.cgi?id=284350
rdar://141197171

Unreviewed revert.

After 287558 at main (with the build fix in 287570 at main), WebKit failed to link with this failure:

WebKit Ld WebKit
Undefined symbols for architecture arm64e:
  "std::__1::optional<JSC::JSValue> IPC::jsValueForDecodedMessage<(IPC::MessageName)2563>(JSC::JSGlobalObject*, IPC::Decoder&)", referenced from:
      IPC::jsValueForArguments(JSC::JSGlobalObject*, IPC::MessageName, IPC::Decoder&) in MessageArgumentDescriptions.o
  "std::__1::optional<JSC::JSValue> IPC::jsValueForDecodedMessage<(IPC::MessageName)3793>(JSC::JSGlobalObject*, IPC::Decoder&)", referenced from:
      IPC::jsValueForArguments(JSC::JSGlobalObject*, IPC::MessageName, IPC::Decoder&) in MessageArgumentDescriptions.o
  "std::__1::optional<JSC::JSValue> IPC::jsValueForDecodedMessageReply<(IPC::MessageName)2559>(JSC::JSGlobalObject*, IPC::Decoder&)", referenced from:
      IPC::jsValueForReplyArguments(JSC::JSGlobalObject*, IPC::MessageName, IPC::Decoder&) in MessageArgumentDescriptions.o
  "std::__1::optional<JSC::JSValue> IPC::jsValueForDecodedMessageReply<(IPC::MessageName)2563>(JSC::JSGlobalObject*, IPC::Decoder&)", referenced from:
      IPC::jsValueForReplyArguments(JSC::JSGlobalObject*, IPC::MessageName, IPC::Decoder&) in MessageArgumentDescriptions.o
  "std::__1::optional<JSC::JSValue> IPC::jsValueForDecodedMessageReply<(IPC::MessageName)3793>(JSC::JSGlobalObject*, IPC::Decoder&)", referenced from:
      IPC::jsValueForReplyArguments(JSC::JSGlobalObject*, IPC::MessageName, IPC::Decoder&) in MessageArgumentDescriptions.o

when building with certain SDKs.

The #undef HAVE_ALLOW_ONLY_PARTITIONED_COOKIES in CFNetworkSPI.h causes the value of HAVE(ALLOW_ONLY_PARTITIONED_COOKIES) to be different in different files.

* LayoutTests/http/tests/cookies/resources/echo-http-and-dom-cookies-and-notify-done.py:
* LayoutTests/http/tests/cookies/resources/set-cookie-and-redirect-back.py:
* LayoutTests/http/tests/storageAccess/grant-with-prompt-under-general-third-party-cookie-blocking-with-partitioned-cookies.https-expected.txt: Removed.
* LayoutTests/http/tests/storageAccess/grant-with-prompt-under-general-third-party-cookie-blocking-with-partitioned-cookies.https.html: Removed.
* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/mac-wk2/TestExpectations:
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WTF/wtf/PlatformHave.h:
* Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h:
* Source/WebCore/platform/network/NetworkStorageSession.cpp:
(WebCore::NetworkStorageSession::thirdPartyCookieBlockingDecisionForRequest const):
(WebCore::NetworkStorageSession::setOptInCookiePartitioningEnabled):
* Source/WebCore/platform/network/NetworkStorageSession.h:
(WebCore::NetworkStorageSession::isOptInCookiePartitioningEnabled const):
* Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm:
(WebCore::cookiesForURLFromStorage):
(WebCore::NetworkStorageSession::httpCookiesForURL const):
(WebCore::NetworkStorageSession::cookiesForURL const):
(WebCore::NetworkStorageSession::deleteCookie const):
* Source/WebKit/NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::setOptInCookiePartitioningEnabled const):
* Source/WebKit/NetworkProcess/NetworkProcess.h:
* Source/WebKit/NetworkProcess/NetworkProcess.messages.in:
* Source/WebKit/NetworkProcess/NetworkSession.cpp:
(WebKit::NetworkSession::setOptInCookiePartitioningEnabled):
* Source/WebKit/NetworkProcess/NetworkSession.h:
(WebKit::NetworkSession::shouldSendPrivateTokenIPCForTesting const):
* Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
* Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::createWebSocketTask):
* Source/WebKit/NetworkProcess/cocoa/NetworkTaskCocoa.h:
* Source/WebKit/NetworkProcess/cocoa/NetworkTaskCocoa.mm:
(WebKit::NetworkTaskCocoa::updateTaskWithStoragePartitionIdentifier):
(WebKit::NetworkTaskCocoa::willPerformHTTPRedirection):
* Source/WebKit/NetworkProcess/cocoa/WebSocketTaskCocoa.mm:
(WebKit::WebSocketTask::WebSocketTask):
* Source/WebKit/Shared/Cocoa/CoreIPCNSURLRequest.h:
* Source/WebKit/Shared/Cocoa/CoreIPCNSURLRequest.mm:
(WebKit::CoreIPCNSURLRequest::CoreIPCNSURLRequest):
(WebKit::CoreIPCNSURLRequest::toID const):
* Source/WebKit/Shared/Cocoa/CoreIPCNSURLRequest.serialization.in:
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::isOptInCookiePartitioningEnabled const):
(WebKit::WebsiteDataStore::propagateSettingUpdatesToNetworkProcess):
(WebKit::WebsiteDataStore::parameters):

Canonical link: https://commits.webkit.org/287585@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications