[webkit-changes] [WebKit/WebKit] b72771: Use UIProcess application bundle identifier if GPU...

youennf noreply at github.com
Mon Dec 9 11:49:56 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b72771d05c674cb27423923b5074f9f7b03994ec
      https://github.com/WebKit/WebKit/commit/b72771d05c674cb27423923b5074f9f7b03994ec
  Author: Youenn Fablet <youenn at apple.com>
  Date:   2024-12-09 (Mon, 09 Dec 2024)

  Changed paths:
    M Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp
    M Source/WebKit/GPUProcess/GPUConnectionToWebProcess.h
    M Source/WebKit/GPUProcess/cocoa/GPUConnectionToWebProcessCocoa.mm
    M Source/WebKit/Shared/GPUProcessConnectionParameters.h
    M Source/WebKit/Shared/GPUProcessConnectionParameters.serialization.in
    M Source/WebKit/UIProcess/WebProcessPool.cpp

  Log Message:
  -----------
  Use UIProcess application bundle identifier if GPUProcess is not able to compute it itself
rdar://140402550
https://bugs.webkit.org/show_bug.cgi?id=284232

Reviewed by Andy Estes.

The call to LSBundleProxy bundleProxyWithAuditToken sometimes fails in GPUProcess.
We send the bundle identifier from UIProcess to GPUProcess so that, if the above call fails, we fallback to the provided bundle identifier.

This ensures that camera capture will not fail in case media environment is not enabled and the LSBundleProxy bundleProxyWithAuditToken call fails.

Manually tested.

* Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp:
* Source/WebKit/GPUProcess/GPUConnectionToWebProcess.h:
(WebKit::GPUConnectionToWebProcess::applicationBundleIdentifier const):
* Source/WebKit/GPUProcess/cocoa/GPUConnectionToWebProcessCocoa.mm:
(WebKit::GPUConnectionToWebProcess::setTCCIdentity):
* Source/WebKit/Shared/GPUProcessConnectionParameters.h:
* Source/WebKit/Shared/GPUProcessConnectionParameters.serialization.in:
* Source/WebKit/UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::createGPUProcessConnection):

Canonical link: https://commits.webkit.org/287561@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list