[webkit-changes] [WebKit/WebKit] 9e55dd: [SwiftUI] Refactor WebPage in preparation for cros...

[Richard Robinson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9e55ddae4fbaac6e3d7174330a461506b397a81e
      https://github.com/WebKit/WebKit/commit/9e55ddae4fbaac6e3d7174330a461506b397a81e
  Author: Richard Robinson <richard_robinson2 at apple.com>
  Date:   2024-12-09 (Mon, 09 Dec 2024)

  Changed paths:
    M Source/WebKit/UIProcess/API/Swift/WebPage+NavigationDeciding.swift
    A Source/WebKit/UIProcess/API/Swift/WebPage+NavigationDecidingSwiftUI.swift
    A Source/WebKit/UIProcess/API/Swift/WebPage+SwiftUI.swift
    M Source/WebKit/UIProcess/API/Swift/WebPage.swift
    M Source/WebKit/UIProcess/API/Swift/WebView.swift
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
    R Tools/TestWebKitAPI/Tests/WebKit Swift/URLSchemeHandler.swift
    A Tools/TestWebKitAPI/Tests/WebKit Swift/URLSchemeHandlerTests.swift
    R Tools/TestWebKitAPI/Tests/WebKit Swift/WKWebViewSwiftOverlay.swift
    A Tools/TestWebKitAPI/Tests/WebKit Swift/WKWebViewSwiftOverlayTests.swift
    R Tools/TestWebKitAPI/Tests/WebKit Swift/WebPage.swift
    A Tools/TestWebKitAPI/Tests/WebKit Swift/WebPageTests.swift

  Log Message:
  -----------
  [SwiftUI] Refactor WebPage in preparation for cross-import overlay
https://bugs.webkit.org/show_bug.cgi?id=284258
rdar://141131840

Reviewed by Aditya Keerthi.

In prepartion for the cross-import overlay, refactor some functions and properties that depend
on SwiftUI into separate files.

Also, rename the test files to have a "Tests" suffix to reduce filename confusion.

* Source/WebKit/UIProcess/API/Swift/WebPage+NavigationDeciding.swift:
(NavigationAction.modifierFlags): Deleted.
* Source/WebKit/UIProcess/API/Swift/WebPage+NavigationDecidingSwiftUI.swift: Copied from Tools/TestWebKitAPI/Tests/WebKit Swift/WKWebViewSwiftOverlay.swift.
(WebPage_v0.modifierFlags):
* Source/WebKit/UIProcess/API/Swift/WebPage+SwiftUI.swift: Copied from Tools/TestWebKitAPI/Tests/WebKit Swift/WKWebViewSwiftOverlay.swift.
(WebPage_v0.themeColor):
* Source/WebKit/UIProcess/API/Swift/WebPage.swift:
(WebPage_v0.url):
(WebPage_v0.title):
(WebPage_v0.estimatedProgress):
(WebPage_v0.isLoading):
(WebPage_v0.serverTrust):
(WebPage_v0.hasOnlySecureContent):
(WebPage_v0.isWritingToolsActive):
(KeyValueObservations.contents):
(WebPage_v0.themeColor): Deleted.
* Source/WebKit/UIProcess/API/Swift/WebView.swift:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/WebKit Swift/URLSchemeHandlerTests.swift: Renamed from Tools/TestWebKitAPI/Tests/WebKit Swift/URLSchemeHandler.swift.
(reply(for:)):
(URLSchemeHandlerTests.basicSchemeValidation):
(URLSchemeHandlerTests.basicSchemeHandling):
* Tools/TestWebKitAPI/Tests/WebKit Swift/WKWebViewSwiftOverlayTests.swift: Renamed from Tools/TestWebKitAPI/Tests/WebKit Swift/WKWebViewSwiftOverlay.swift.
(WKWebViewSwiftOverlayTests.evaluateJavaScriptYieldsExpectedResponse):
(WKWebViewSwiftOverlayTests.evaluateJavaScriptWithNilResponse):
* Tools/TestWebKitAPI/Tests/WebKit Swift/WebPageTests.swift: Renamed from Tools/TestWebKitAPI/Tests/WebKit Swift/WebPage.swift.
(TestNavigationDecider.preferencesMutation):
(TestNavigationDecider.decidePolicy(for:preferences:)):
(TestNavigationDecider.decidePolicy(for:)):
(WebPageTests.basicNavigation):
(WebPageTests.sequenceOfNavigations):
(WebPageTests.navigationWithFailedProvisionalNavigationEvent):
(WebPageTests.observableProperties):
(WebPageTests.decidePolicyForNavigationActionFragment):
(WebPageTests.navigationPreferencesMutationDuringNavigation):
(WebPageTests.javaScriptEvaluation):
(WebPageTests.decidePolicyForNavigationResponse):

Canonical link: https://commits.webkit.org/287550@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications