[webkit-changes] [WebKit/WebKit] d2eb15: Cleanup visitorAdditionalChildren methods in Obser...

[Marais Rossouw]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d2eb155406a34a0d0fda399a81d4667205a01271
      https://github.com/WebKit/WebKit/commit/d2eb155406a34a0d0fda399a81d4667205a01271
  Author: Marais Rossouw <me at marais.co>
  Date:   2024-12-09 (Mon, 09 Dec 2024)

  Changed paths:
    M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
    M Source/WebCore/dom/InternalObserver.h
    M Source/WebCore/dom/InternalObserverDrop.cpp
    M Source/WebCore/dom/InternalObserverEvery.cpp
    M Source/WebCore/dom/InternalObserverFilter.cpp
    M Source/WebCore/dom/InternalObserverFind.cpp
    M Source/WebCore/dom/InternalObserverFirst.cpp
    M Source/WebCore/dom/InternalObserverForEach.cpp
    M Source/WebCore/dom/InternalObserverFromScript.cpp
    M Source/WebCore/dom/InternalObserverFromScript.h
    M Source/WebCore/dom/InternalObserverInspect.cpp
    M Source/WebCore/dom/InternalObserverLast.cpp
    M Source/WebCore/dom/InternalObserverMap.cpp
    M Source/WebCore/dom/InternalObserverSome.cpp
    M Source/WebCore/dom/InternalObserverTake.cpp
    M Source/WebCore/dom/Observable.idl
    M Source/WebCore/dom/Subscriber.cpp
    M Source/WebCore/dom/Subscriber.h

  Log Message:
  -----------
  Cleanup visitorAdditionalChildren methods in Observables code
https://bugs.webkit.org/show_bug.cgi?id=284257

Reviewed by Chris Dumez.

AbstractSlotVisitor is a bass class to SlotVisitor, as such
we have no need to house duplicate implementions of the
visitorAdditionalChildren methods that each accept one of those as
arguments; and instead just accept a AbstractSlotVisitor.

We also drive-by cleaned up some mac-safer things, for example created
stack variables for RefPtrs.

* Source/WebCore/dom/InternalObserver.h:
* Source/WebCore/dom/InternalObserverDrop.cpp:
* Source/WebCore/dom/InternalObserverEvery.cpp:
* Source/WebCore/dom/InternalObserverFilter.cpp:
* Source/WebCore/dom/InternalObserverFind.cpp:
* Source/WebCore/dom/InternalObserverFirst.cpp:
* Source/WebCore/dom/InternalObserverForEach.cpp:
* Source/WebCore/dom/InternalObserverFromScript.cpp:
* Source/WebCore/dom/InternalObserverFromScript.h:
* Source/WebCore/dom/InternalObserverInspect.cpp:
* Source/WebCore/dom/InternalObserverLast.cpp:
* Source/WebCore/dom/InternalObserverMap.cpp:
* Source/WebCore/dom/InternalObserverSome.cpp:
* Source/WebCore/dom/InternalObserverTake.cpp:
* Source/WebCore/dom/Observable.idl:
* Source/WebCore/dom/Subscriber.cpp:
* Source/WebCore/dom/Subscriber.h:
* Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:

Canonical link: https://commits.webkit.org/287546@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications