[webkit-changes] [WebKit/WebKit] 76c95d: Don't update height in RenderBlock::markFixedPosit...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 76c95d6131edd36775a5eac01e297926fc974be8
      https://github.com/WebKit/WebKit/commit/76c95d6131edd36775a5eac01e297926fc974be8
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-12-09 (Mon, 09 Dec 2024)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/css-position/absolute-pos-box-inside-fixed-pos-box-with-changing-height-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-position/absolute-pos-box-inside-fixed-pos-box-with-changing-height-ref.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-position/absolute-pos-box-inside-fixed-pos-box-with-changing-height.html
    M Source/WebCore/rendering/RenderBlock.cpp

  Log Message:
  -----------
  Don't update height in RenderBlock::markFixedPositionObjectForLayoutIfNeeded
https://bugs.webkit.org/show_bug.cgi?id=284120

Reviewed by Antti Koivisto.

Inspired by blink's commit of https://chromium.googlesource.com/chromium/src.git/+/1abcf254f3e55be39879ca76d268192faf64a254.

In markFixedPositionObjectForLayoutIfNeeded we should really just check if position is going
to change (and mark content dirty accordingly) as opposed to actually set geometry values.

* LayoutTests/imported/w3c/web-platform-tests/css/css-position/absolute-pos-box-inside-fixed-pos-box-with-changing-height-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-position/absolute-pos-box-inside-fixed-pos-box-with-changing-height-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-position/absolute-pos-box-inside-fixed-pos-box-with-changing-height.html: Added.
* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::RenderBlock::markFixedPositionObjectForLayoutIfNeeded):

Canonical link: https://commits.webkit.org/287541@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications