[webkit-changes] [WebKit/WebKit] 791380: [WebGPU] WebGPU Metaballs sample is missing the st...

mwyrzykowski noreply at github.com
Sun Dec 8 20:40:39 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 79138082ae0654bc1defd0add90a1ae86504b1aa
      https://github.com/WebKit/WebKit/commit/79138082ae0654bc1defd0add90a1ae86504b1aa
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-12-08 (Sun, 08 Dec 2024)

  Changed paths:
    A LayoutTests/fast/webgpu/regression/repro_284238-expected.txt
    A LayoutTests/fast/webgpu/regression/repro_284238.html
    M Source/WebGPU/WebGPU/Device.mm

  Log Message:
  -----------
  [WebGPU] WebGPU Metaballs sample is missing the stone ring
https://bugs.webkit.org/show_bug.cgi?id=284238
rdar://141108427

Reviewed by Tadeu Zagallo.

We were not accounting for firstIndex or indexBufferOffset when performing
ICB index validation, leading to incorrect bounds checking.

* LayoutTests/fast/webgpu/regression/repro_284238-expected.txt: Added.
* LayoutTests/fast/webgpu/regression/repro_284238.html: Added.
Add regression test.

* Source/WebGPU/WebGPU/Device.mm:
Need to account for the first index.

Canonical link: https://commits.webkit.org/287535@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list