[webkit-changes] [WebKit/WebKit] 8b8073: Implement Observable#inspect

[Marais Rossouw]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8b80739ea60b5d9b0a7cd7a9152c4e5b15ff8137
      https://github.com/WebKit/WebKit/commit/8b80739ea60b5d9b0a7cd7a9152c4e5b15ff8137
  Author: Marais Rossouw <me at marais.co>
  Date:   2024-12-07 (Sat, 07 Dec 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-inspect.any-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-inspect.any.worker-expected.txt
    M Source/WebCore/CMakeLists.txt
    M Source/WebCore/DerivedSources-input.xcfilelist
    M Source/WebCore/DerivedSources.make
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    A Source/WebCore/dom/InternalObserverInspect.cpp
    A Source/WebCore/dom/InternalObserverInspect.h
    M Source/WebCore/dom/Observable.cpp
    M Source/WebCore/dom/Observable.h
    M Source/WebCore/dom/Observable.idl
    A Source/WebCore/dom/ObservableInspector.h
    A Source/WebCore/dom/ObservableInspector.idl
    A Source/WebCore/dom/ObservableInspectorAbortCallback.h
    A Source/WebCore/dom/ObservableInspectorAbortCallback.idl

  Log Message:
  -----------
  Implement Observable#inspect
https://bugs.webkit.org/show_bug.cgi?id=282083

Reviewed by Chris Dumez.

This change introduces the .inspect operator for Observables, using the
InternalObserver, and a new SubscriberCallbackInspect. .inspect is meant to act
as a pass-through operator, so there are no mutations on events.

Spec: <https://wicg.github.io/observable/#dom-observable-inspect>

There is also a new ObservableInspector IDL dictionary created, as well as a
ObservableInspectorAbortCallback. We could not just have used some generic
callback IDL, given we require a callback that accepts a JSC::Value, as we
forward abort reasons to this callback.

* LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-inspect.any-expected.txt: Rebaseline.
* LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-inspect.any.worker-expected.txt: Rebaseline.
* Source/WebCore/CMakeLists.txt:
* Source/WebCore/DerivedSources-input.xcfilelist:
* Source/WebCore/DerivedSources.make:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/dom/InternalObserverInspect.cpp: Added.
(WebCore::createSubscriberCallbackInspect):
* Source/WebCore/dom/InternalObserverInspect.h: Added.
* Source/WebCore/dom/Observable.cpp:
(WebCore::Observable::inspect):
* Source/WebCore/dom/Observable.h:
* Source/WebCore/dom/Observable.idl:
Exposes a `Observable inspect(inspectorUnion)` operator.
* Source/WebCore/dom/ObservableInspector.h: Added.
* Source/WebCore/dom/ObservableInspector.idl: Added.
* Source/WebCore/dom/ObservableInspectorAbortCallback.h: Added.
* Source/WebCore/dom/ObservableInspectorAbortCallback.idl: Added.

Canonical link: https://commits.webkit.org/287504@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications