[webkit-changes] [WebKit/WebKit] b17d39: [WebGPU] 'auto' GPUBindGroupLayout creation allows...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b17d39f2c8ce8c24af4964676ad0cdb5f30ab7ac
      https://github.com/WebKit/WebKit/commit/b17d39f2c8ce8c24af4964676ad0cdb5f30ab7ac
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-12-07 (Sat, 07 Dec 2024)

  Changed paths:
    A LayoutTests/fast/webgpu/nocrash/fuzz-283998-expected.txt
    A LayoutTests/fast/webgpu/nocrash/fuzz-283998.html
    M Source/WebGPU/WebGPU/BindGroup.h
    M Source/WebGPU/WebGPU/BindGroup.mm
    M Source/WebGPU/WebGPU/ComputePassEncoder.mm
    M Source/WebGPU/WebGPU/PipelineLayout.h
    M Source/WebGPU/WebGPU/PipelineLayout.mm
    M Source/WebGPU/WebGPU/RenderBundleEncoder.mm
    M Source/WebGPU/WebGPU/RenderPassEncoder.mm

  Log Message:
  -----------
  [WebGPU] 'auto' GPUBindGroupLayout creation allows for mixing bind groups at different locations
https://bugs.webkit.org/show_bug.cgi?id=283998
rdar://140802793

Reviewed by Tadeu Zagallo.

With auto layouts, @group(K) @binding(X) must correspond
to a bind group created from layout K and placed at bind
group X in the call to setBindGroup(bindGroup, index=K)

* Source/WebGPU/WebGPU/BindGroup.h:
* Source/WebGPU/WebGPU/BindGroup.mm:
(WebGPU::BindGroup::makeSubmitInvalid const):
* Source/WebGPU/WebGPU/ComputePassEncoder.mm:
(WebGPU::ComputePassEncoder::executePreDispatchCommands):
* Source/WebGPU/WebGPU/PipelineLayout.h:
* Source/WebGPU/WebGPU/PipelineLayout.mm:
(WebGPU::PipelineLayout::optionalBindGroupLayout const):
* Source/WebGPU/WebGPU/RenderBundleEncoder.mm:
(WebGPU::RenderBundleEncoder::executePreDrawCommands):
* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::executePreDrawCommands):

Canonical link: https://commits.webkit.org/287499@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications