[webkit-changes] [WebKit/WebKit] 3f5a86: Address most remaining GPU Process WebGPU Safer C+...

Cameron McCormack noreply at github.com
Fri Dec 6 19:42:32 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3f5a86e7387105020a4508a144336eeb4cba7b07
      https://github.com/WebKit/WebKit/commit/3f5a86e7387105020a4508a144336eeb4cba7b07
  Author: Cameron McCormack <heycam at apple.com>
  Date:   2024-12-06 (Fri, 06 Dec 2024)

  Changed paths:
    M Source/WebGPU/WebGPU/BindGroup.h
    M Source/WebGPU/WebGPU/BindGroup.mm
    M Source/WebGPU/WebGPU/BindGroupLayout.mm
    M Source/WebGPU/WebGPU/RenderBundleEncoder.mm
    M Source/WebGPU/WebGPU/RenderPassEncoder.mm
    M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteComputePassEncoderProxy.cpp
    M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteComputePassEncoderProxy.h

  Log Message:
  -----------
  Address most remaining GPU Process WebGPU Safer C++ errors
https://bugs.webkit.org/show_bug.cgi?id=284192
rdar://141067147

Reviewed by Mike Wyrzykowski.

And a couple of Web Process ones that were in the same report I was
looking at.

After this patch, there is one remaining GPU Process WebGPU error,
which could be an incorrect error from the analyzer.

* Source/WebGPU/WebGPU/BindGroup.h:
(WebGPU::BindGroup::protectedBindGroupLayout const):
* Source/WebGPU/WebGPU/BindGroup.mm:
(WebGPU::BindGroup::makeSubmitInvalid const):
* Source/WebGPU/WebGPU/BindGroupLayout.mm:
(WebGPU::Device::createBindGroupLayout):
* Source/WebGPU/WebGPU/RenderBundleEncoder.mm:
(WebGPU::RenderBundleEncoder::executePreDrawCommands):
* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::clampIndexBufferToValidValues):
(WebGPU::RenderPassEncoder::executeBundles):
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteComputePassEncoderProxy.cpp:
(WebKit::WebGPU::RemoteComputePassEncoderProxy::setPipeline):
(WebKit::WebGPU::RemoteComputePassEncoderProxy::dispatchIndirect):
(WebKit::WebGPU::RemoteComputePassEncoderProxy::setBindGroup):
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteComputePassEncoderProxy.h:

Canonical link: https://commits.webkit.org/287490@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list