[webkit-changes] [WebKit/WebKit] f09cec: REGRESSION(284617 at main): Media query does not reco...

[Said Abou-Hallawa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f09cec069734290b173a7002a6aa99be3dc14aa0
      https://github.com/WebKit/WebKit/commit/f09cec069734290b173a7002a6aa99be3dc14aa0
  Author: Said Abou-Hallawa <said at apple.com>
  Date:   2024-12-06 (Fri, 06 Dec 2024)

  Changed paths:
    M Source/WebCore/css/query/MediaQueryFeatures.cpp
    M Source/WebCore/platform/PlatformScreen.h
    M Source/WebCore/platform/ScreenProperties.h
    M Source/WebCore/platform/ios/PlatformScreenIOS.mm
    M Source/WebCore/platform/mac/PlatformScreenMac.mm
    M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in

  Log Message:
  -----------
  REGRESSION(284617 at main): Media query does not recognize the p3 color-gamut display
https://bugs.webkit.org/show_bug.cgi?id=284135
rdar://138933101

Reviewed by Simon Fraser.

284617 at main changed `colorGamut()` such that it checks for the display-p3 color
gamut only when HAVE(IOSURFACE_RGB10) which is enabled on iOS only.

screenProperties should not use screenContentsFormat to set its fields. In fact
the opposite should happen.

The fix is to revert some of the changes in 284617 at main.

1. A bool flag screenSupportsExtendedColor will replace screenContentsFormat
   in ScreenData.

2. The function screenSupportsExtendedColor() will be readded. It will be used
   by screenContentsFormat().

3. colorGamut() will replace the call to screenContentsFormat() by calling
   screenSupportsExtendedColor().

* Source/WebCore/css/query/MediaQueryFeatures.cpp:
(WebCore::MQ::Features::colorGamut):
* Source/WebCore/platform/PlatformScreen.h:
* Source/WebCore/platform/ScreenProperties.h:
* Source/WebCore/platform/ios/PlatformScreenIOS.mm:
(WebCore::screenContentsFormat):
(WebCore::screenSupportsExtendedColor):
(WebCore::collectScreenProperties):
* Source/WebCore/platform/mac/PlatformScreenMac.mm:
(WebCore::collectScreenProperties):
(WebCore::screenContentsFormat):
(WebCore::screenSupportsExtendedColor):
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:

Canonical link: https://commits.webkit.org/287482@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications