[webkit-changes] [WebKit/WebKit] aff19f: AX: Set non-style-related attributes when serving ...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: aff19f98fb652ba02cd995f7ee6b568864f5750f
      https://github.com/WebKit/WebKit/commit/aff19f98fb652ba02cd995f7ee6b568864f5750f
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2024-12-06 (Fri, 06 Dec 2024)

  Changed paths:
    A LayoutTests/accessibility/ax-thread-text-apis/attributed-string-includes-insertion-deletion-expected.txt
    A LayoutTests/accessibility/ax-thread-text-apis/attributed-string-includes-insertion-deletion.html
    M LayoutTests/accessibility/ax-thread-text-apis/attributed-string/attributed-string-text-styling.html
    A LayoutTests/accessibility/ax-thread-text-apis/attributed-string/blockquote-level-expected.txt
    A LayoutTests/accessibility/ax-thread-text-apis/attributed-string/blockquote-level.html
    A LayoutTests/accessibility/ax-thread-text-apis/attributed-string/expanded-text-expected.txt
    A LayoutTests/accessibility/ax-thread-text-apis/attributed-string/expanded-text.html
    A LayoutTests/accessibility/ax-thread-text-apis/attributed-string/heading-level-expected.txt
    A LayoutTests/accessibility/ax-thread-text-apis/attributed-string/heading-level.html
    A LayoutTests/accessibility/ax-thread-text-apis/attributed-string/lazy-spellchecking-expected.txt
    A LayoutTests/accessibility/ax-thread-text-apis/attributed-string/lazy-spellchecking.html
    A LayoutTests/accessibility/ax-thread-text-apis/attributed-string/link-text-expected.txt
    A LayoutTests/accessibility/ax-thread-text-apis/attributed-string/link-text.html
    M LayoutTests/accessibility/ax-thread-text-apis/character-offset-from-upstream-position.html
    A LayoutTests/accessibility/ax-thread-text-apis/mark-role-expected.txt
    A LayoutTests/accessibility/ax-thread-text-apis/mark-role.html
    M Source/WebCore/accessibility/AXCoreObject.h
    M Source/WebCore/accessibility/AXLogger.cpp
    M Source/WebCore/accessibility/AXTextMarker.cpp
    M Source/WebCore/accessibility/AccessibilityObject.h
    M Source/WebCore/accessibility/cocoa/AXCoreObjectCocoa.mm
    M Source/WebCore/accessibility/cocoa/AXTextMarkerCocoa.mm
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h
    M Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm
    M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.h

  Log Message:
  -----------
  AX: Set non-style-related attributes when serving attributed strings from the accessibility thread
https://bugs.webkit.org/show_bug.cgi?id=284117
rdar://140996511

Reviewed by Chris Fleizach.

With this commit, we set many new attributes for attributed strings created lazily off the main-thread:
  - AXHighlight
  - AXIsSuggestedInsertion
  - AXIsSuggestedDeletion
  - AXIsSuggestion
  - AXLink
  - AXExpandedTextValue
  - AXHeadingLevel
  - AXBlockQuoteLevel
  - AXDidSpellCheck

After this commit, the two remaining attributes are related to eagerly resolving misspelling (rather than setting AXDidSpellCheck: 0),
and setting text autocompletion attributes (attributedStringSetCompositionAttributes), both of which currently require DOM nodes
or other main-thread state. We'll figure out what to do with these in a future patch.

Many new tests are added to verify we behave correctly.

* LayoutTests/accessibility/ax-thread-text-apis/attributed-string-includes-insertion-deletion-expected.txt: Added.
* LayoutTests/accessibility/ax-thread-text-apis/attributed-string-includes-insertion-deletion.html: Added.
* LayoutTests/accessibility/ax-thread-text-apis/attributed-string/attributed-string-text-styling.html:
* LayoutTests/accessibility/ax-thread-text-apis/attributed-string/blockquote-level-expected.txt: Added.
* LayoutTests/accessibility/ax-thread-text-apis/attributed-string/blockquote-level.html: Added.
* LayoutTests/accessibility/ax-thread-text-apis/attributed-string/expanded-text-expected.txt: Added.
* LayoutTests/accessibility/ax-thread-text-apis/attributed-string/expanded-text.html: Added.
* LayoutTests/accessibility/ax-thread-text-apis/attributed-string/heading-level-expected.txt: Added.
* LayoutTests/accessibility/ax-thread-text-apis/attributed-string/heading-level.html: Added.
* LayoutTests/accessibility/ax-thread-text-apis/attributed-string/lazy-spellchecking-expected.txt: Added.
* LayoutTests/accessibility/ax-thread-text-apis/attributed-string/lazy-spellchecking.html: Added.
* LayoutTests/accessibility/ax-thread-text-apis/attributed-string/link-text-expected.txt: Added.
* LayoutTests/accessibility/ax-thread-text-apis/attributed-string/link-text.html: Added.
* LayoutTests/accessibility/ax-thread-text-apis/character-offset-from-upstream-position.html:
* LayoutTests/accessibility/ax-thread-text-apis/mark-role-expected.txt: Added.
* LayoutTests/accessibility/ax-thread-text-apis/mark-role.html: Added.
* Source/WebCore/accessibility/AXCoreObject.h:
(WebCore::Accessibility::editableAncestor):
* Source/WebCore/accessibility/AXLogger.cpp:
(WebCore::operator<<):
* Source/WebCore/accessibility/AXTextMarker.cpp:
* Source/WebCore/accessibility/AccessibilityObject.h:
* Source/WebCore/accessibility/cocoa/AXCoreObjectCocoa.mm:
(WebCore::attributedStringSetColor):
(WebCore::attributedStringSetExpandedText):
(WebCore::attributedStringSetBlockquoteLevel):
(WebCore::attributedStringSetNeedsSpellCheck):
(WebCore::attributedStringSetElement):
(WebCore::attributedStringSetStyle):
(WebCore::AXCoreObject::createAttributedString const):
* Source/WebCore/accessibility/cocoa/AXTextMarkerCocoa.mm:
(WebCore::AXTextMarkerRange::toAttributedString const):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::initializeProperties):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:
* Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm:
(WebCore::attributedStringCreate):
(WebCore::attributedStringSetStyle): Deleted.
(WebCore::attributedStringSetHeadingLevel): Deleted.
(WebCore::attributedStringSetBlockquoteLevel): Deleted.
(WebCore::attributedStringSetExpandedText): Deleted.
(WebCore::attributedStringSetElement): Deleted.
(WebCore::attributedStringSetNeedsSpellCheck): Deleted.
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.h:

Canonical link: https://commits.webkit.org/287471@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications