[webkit-changes] [WebKit/WebKit] b1d0fe: [WebAuthn] Fixing the Assert condition that was wr...

nmahendru noreply at github.com
Fri Dec 6 15:50:34 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b1d0fe1e0f908249f3725d1b7459cff303b2427a
      https://github.com/WebKit/WebKit/commit/b1d0fe1e0f908249f3725d1b7459cff303b2427a
  Author: Nitin Mahendru <nitinmahendru at apple.com>
  Date:   2024-12-06 (Fri, 06 Dec 2024)

  Changed paths:
    M LayoutTests/platform/ios/TestExpectations
    M LayoutTests/platform/mac-wk2/TestExpectations
    M Source/WebKit/UIProcess/WebAuthentication/fido/U2fAuthenticator.cpp

  Log Message:
  -----------
  [WebAuthn] Fixing the Assert condition that was wrongly inverted.
https://bugs.webkit.org/show_bug.cgi?id=283740
radar://140607217

Reviewed by Pascoe and John Wilander.

In 286655 at main I added a log message for an ASSERT and mistakenly inverted the
conditional inside it. This change fixes that.
It also removes the Failure text expectations as the test was already fixed in
https://bugs.webkit.org/show_bug.cgi?id=274807

* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/mac-wk2/TestExpectations:
* Source/WebKit/UIProcess/WebAuthentication/fido/U2fAuthenticator.cpp:
(WebKit::U2fAuthenticator::continueSignCommandAfterResponseReceived):

Canonical link: https://commits.webkit.org/287464@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list