[webkit-changes] [WebKit/WebKit] e5e3a6: [AutoInstall] retry logic doesn't actually throw o...

Sam Sneddon noreply at github.com
Fri Dec 6 15:33:15 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e5e3a6a6bf1460a1b3216398925a353420cc6176
      https://github.com/WebKit/WebKit/commit/e5e3a6a6bf1460a1b3216398925a353420cc6176
  Author: Sam Sneddon <gsnedders at apple.com>
  Date:   2024-12-06 (Fri, 06 Dec 2024)

  Changed paths:
    M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py
    A Tools/Scripts/libraries/webkitcorepy/webkitcorepy/tests/autoinstall_unittest.py

  Log Message:
  -----------
  [AutoInstall] retry logic doesn't actually throw on eventual failure
https://bugs.webkit.org/show_bug.cgi?id=284133

Reviewed by Jonathan Bedard.

Our retry logic has actually been broken since it first landed, never
actually raising upon failure. This both fixes the conditional and
adds a test for this behaviour, including how many retries we make.

* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:
(Package.Archive.download):
* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/tests/autoinstall_unittest.py: Added.
(ArchiveTest):
(ArchiveTest.test_retry):

Canonical link: https://commits.webkit.org/287456@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list