[webkit-changes] [WebKit/WebKit] acc601: [WGSL] webgpu:shader, validation, types, textures:* i...

Tadeu Zagallo noreply at github.com
Fri Dec 6 05:58:11 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: acc6013cc7d131e651562ee3c17d9bf57f7978c5
      https://github.com/WebKit/WebKit/commit/acc6013cc7d131e651562ee3c17d9bf57f7978c5
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2024-12-06 (Fri, 06 Dec 2024)

  Changed paths:
    M Source/WebGPU/WGSL/TypeCheck.cpp

  Log Message:
  -----------
  [WGSL] webgpu:shader,validation,types,textures:* is failing
https://bugs.webkit.org/show_bug.cgi?id=284050
rdar://140923477

Reviewed by Mike Wyrzykowski.

According to the spec[1], using an invalid texel format should not be a shader
creation error, which was happening before as the `bgra8unorm` value was conditionally
defined based on the feature being available, which raised a type error at shader
creation time.

[1]: https://www.w3.org/TR/WGSL/#texture-storage

* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::TypeChecker):

Canonical link: https://commits.webkit.org/287444@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list