[webkit-changes] [WebKit/WebKit] cd5c9f: [Floats] Citi.com login renders incorrectly, login...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cd5c9f5b269686949a2f5972e5d2c7e146c52739
      https://github.com/WebKit/WebKit/commit/cd5c9f5b269686949a2f5972e5d2c7e146c52739
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-12-06 (Fri, 06 Dec 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    A LayoutTests/fast/block/float/float-with-negative-margin-formatting-context-root-expected.html
    A LayoutTests/fast/block/float/float-with-negative-margin-formatting-context-root.html
    M Source/WebCore/rendering/RenderBox.cpp

  Log Message:
  -----------
  [Floats] Citi.com login renders incorrectly, login field is shrunk to the side
https://bugs.webkit.org/show_bug.cgi?id=284143
<rdar://140472029>

Unreviewed revert.

This is a revert of 283298 at main (and its follow-up fix of 286637 at main>).

Apparently part of the layout code relies on the fact that negative margins make the available space wider (they don't).
While adjusting the caller logic (RenderBlockFlow::getClearDelta) fixes this incorrect behavior, it also already introduced a regression -see 249370 at main (which later got reverted).

* LayoutTests/TestExpectations:
* LayoutTests/fast/block/float/float-with-negative-margin-formatting-context-root-expected.html: Added.
* LayoutTests/fast/block/float/float-with-negative-margin-formatting-context-root.html: Added.
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::shrinkLogicalWidthToAvoidFloats const):

Canonical link: https://commits.webkit.org/287442@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications